Repository navigation
feat: map the Live Tools and general members from the 1.74.0 gap report - #422
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 7 |
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
danielabbatt
force-pushed
the
feat/map-switch-camera-sensor-cellular-members
branch
from
September 29, 2026 12:15
1944160 to
12771be
Compare
danielabbatt
force-pushed
the
feat/map-livetools-general-members
branch
from
September 29, 2026 12:15
bfc5def to
18d6fd4
Compare
danielabbatt
force-pushed
the
feat/map-switch-camera-sensor-cellular-members
branch
from
September 29, 2026 12:43
12771be to
b955769
Compare
danielabbatt
force-pushed
the
feat/map-livetools-general-members
branch
from
September 29, 2026 12:43
18d6fd4 to
e545f96
Compare
danielabbatt
force-pushed
the
feat/map-switch-camera-sensor-cellular-members
branch
from
September 29, 2026 12:52
b955769 to
c41682d
Compare
danielabbatt
force-pushed
the
feat/map-livetools-general-members
branch
from
September 29, 2026 12:52
e545f96 to
b3ad985
Compare
Nineteen members the v1.74.0 spec documents that the models lacked, the sixth and last per-area batch, which closes every member the report listed: Client.Cdp; ClientProvision.ClientId and .Message; DeviceClient .AdaptivePolicyGroup and .Switchport; Mac on both MAC-table request types; IpVersion, Vrf and VrfType on the multicast routing interface and route types; Events.ClientMac; LiveToolsArpTableResultTableEntry.Interface; LiveToolsThroughputTestCreateResponse.ThroughputTestId; and the API's current startTime/endTime and received names alongside the legacy ones on LossAndLatencyHistory, SubclassApplicationUsage and SubclassUsageHistory. Find-MissingModelMembers.ps1 now reports no unmapped response members against v1.74.0. LiveToolsGeneralMemberTests covers the batch. Find-MissingModelMembers.ps1 also stops crashing when nothing is unmapped: the summary line indexed .ClrType on an empty array, which Set-StrictMode rejects.
danielabbatt
force-pushed
the
feat/map-switch-camera-sensor-cellular-members
branch
from
September 29, 2026 12:56
c41682d to
6a7e60f
Compare
danielabbatt
force-pushed
the
feat/map-livetools-general-members
branch
from
September 29, 2026 12:56
b3ad985 to
1eea377
Compare
danielabbatt
changed the base branch from
feat/map-switch-camera-sensor-cellular-members
to
main
September 29, 2026 13:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #421, in the chain that starts at #415
Base is
feat/map-switch-camera-sensor-cellular-members. Merge the chain in order with merge commits, then retarget this tomain. Changelog label1.74.12assumes that.What
Sixth and last per-area batch from
gap-report-v1.74.0.md: 19 Live Tools and general members, all scalars exceptClient.Cdp.ClientCdpasList<List<string>>?, because the API returns CDP as a list of two-element name/value listsClientProvisionClientId,MessageDeviceClientAdaptivePolicyGroup,SwitchportDeviceLiveToolsMacTable{Create,Get}ResponseRequestMacDeviceLiveToolsMulticastRoutingGetResponse{Interface,Route}IpVersion,Vrf(+VrfTypeon the interface)EventsClientMacLiveToolsArpTableResultTableEntryInterfaceLiveToolsThroughputTestCreateResponseThroughputTestIdLossAndLatencyHistory,SubclassApplicationUsage,SubclassUsageHistorystartTime/endTime/receivedalongside the legacystartTs/endTs/recv. As withWifiin #420, I don't know which set the live API sends, so nothing was removedWhere this leaves the gap report
After this chain merges,
Find-MissingModelMembers.ps1reports 0 unmapped response members against v1.74.0 (from 155). What it still reports, and what this series did not touch:Both need their own pass; the ApiChecker project is the existing tool for the endpoint side.
Verification
All 13 edited files kept their BOM state.
The follow-up fix to
Find-MissingModelMembers.ps1(it crashed underSet-StrictModeonce nothing was unmapped) is folded into this PR's single commit.