Read table existence from query result rows - #30
Merged
Merged
Conversation
alexstandiford
force-pushed
the
codex/table-exists-array-contract
branch
from
September 21, 2026 01:26
1a7ec47 to
68091d2
Compare
alexstandiford
force-pushed
the
codex/table-exists-array-contract
branch
from
September 21, 2026 01:33
68091d2 to
96ab539
Compare
alexstandiford
changed the base branch from
codex/coordinated-query-strategy
to
main
September 28, 2026 18:00
alexstandiford
marked this pull request as ready for review
September 28, 2026 18:01
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
TableExistsStrategy::exists()now readsDatabaseStrategy::query()as an array and checksinformation_schema.TABLESwith an active-schema-scoped exact predicate. Literal%and_characters no longer act asLIKEwildcards. The real MySQL regression includes wildcard-shaped absent names alongside matching decoy tables.The result contract is explicit: an empty metadata result means absence, query failure preserves the existing false result, and malformed result or row shapes raise
UnexpectedValueExceptioninstead of being silently treated as absence.Stack
This draft is based on coordinated query PR #28 at
23d08b97ffc2d21c81f921fe944cc5451acddfed. It is the review base for retirement PR #29.Proof
Against isolated MySQL 8.4.11:
libandtestsNo merge, release, tag, or deployment is included.