Repository navigation
Use a bundler default that works with Ruby 3.3 - #40
Merged
Merged
Conversation
The Ruby default is now 3.3, but the bundler default was still 2.1.4 (2.3.14 for elixir), which crashes with SystemStackError on Ruby 3.3. Bump to 2.5.23. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
d2b8506set the default Ruby oflawa-ci,lawa-reportand thelawa-*-ciworkflows to 3.3, but the defaultruby-bundler-versionis still 2.1.4 (2.3.14 for elixir). bundler 2.1.4 crashes on Ruby 3.3 (SystemStackError: stack level too deepwhen runninglawa), so any caller relying on the defaults fails the license check. Callers on ubuntu-26.04 also can't fall back to the old Ruby 3.1.x defaults, since no 3.1.x is built there.Change
ruby-bundler-versionto2.5.23inlawa-ci,lawa-report,lawa-js-ci,lawa-npm-ciandlawa-elixir-ci.lawa-ruby-cialready defaults to 2.5.4.Callers that pass
ruby-bundler-versionexplicitly are unaffected.Follow-up
v1/v2tags still point at older commits (v1pins setup-ruby v1.178.0, which fails on ubuntu-26.04). A release/tag move is needed for consumers using@v1; not done here.ruby-bundler-version(build(API): fix CI on ubuntu-26.04 runners strings-openapi#1351); a follow-up there will drop it once this is released.🤖 Generated with Claude Code