Repository navigation
gh-161458: Move test_winconsoleio and test_file_eintr into test_io - #161460
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…t_free_threading Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The test_free_threading package skipped these on GIL builds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It goes stale whenever a module is added or moved. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cmaloney
added
skip news
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @cmaloney for commit 03f4f2f 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F161460%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
There was a problem hiding this comment.
Hmm, don't all free-threading tests live there, I generally thought we keep them there?
There was a problem hiding this comment.
Currently everything but asyncio. Given free threading is becoming the standard and this has very little "common" free threading needs I'd like if can do next to other module pieces / it's part of what I need to keep working while I modify things..
For this my particular goal is being able to easily go from _io -> [_io, _ionibbler] which is easier to do with them largely in one place. There's currently infra in test_io/utils.py for _pyio vs _io (although I want the _ionibbler to be a little different shape than that if I can)
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM. I'm fine with Lib/test/test_free_threading/test_io.py => Lib/test/test_io/test_free_threading.py move. This test doesn't use anything from test_free_desktop package. It implements its own ThreadSafetyMixin.
|
Refleak buildbots failed with Alpine is already failing on the main branch, it's unrelated to this change. |
|
Looking through bots and actions this is still getting run by NoGIL buildbots and skipped by regular ones; buildbot failures are independent of this change; thanks @vstinner for investigating. With the last restructing more backports needed to be manual; if you run into any feel free to ping me and I'll take care of them. |
|
In general, we do backport test refactoring changes to reduce the risk of merge conflicts on following test backports. |
cmaloney
added
needs backport to 3.14
|
Thanks @cmaloney for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
GH-161523 is a backport of this pull request to the 3.15 branch. |
…t_io (GH-161460) (#161523) gh-161458: Move test_winconsoleio and test_file_eintr into test_io (GH-161460) * gh-161458: Move test_file_eintr into test_io * gh-161458: Move test_winconsoleio into test_io * gh-161458: Move test_free_threading/test_io into test_io as test_free_threading * gh-161458: Skip test_io.test_free_threading on GIL builds The test_free_threading package skipped these on GIL builds. * gh-161458: Remove the test module list from the test_io docstring It goes stale whenever a module is added or moved. * gh-161458: Point to I/O tests outside test_io in its docstring (cherry picked from commit 5106b91) Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Missed these tests in earlier centralizing. Update the
test_iocomment to talk about what isn't in the folder rather than what is in it.