Skip to content

gh-161458: Move test_winconsoleio and test_file_eintr into test_io #161460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmaloney merged 6 commits into from
Nov 6, 2026
Merged

gh-161458: Move test_winconsoleio and test_file_eintr into test_io #161460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a29db8a
gh-161458: Move test_file_eintr into test_io
cmaloney Nov 6, 2026
f98464f
gh-161458: Move test_winconsoleio into test_io
cmaloney Nov 6, 2026
c5fc99b
gh-161458: Move test_free_threading/test_io into test_io as test_free…
cmaloney Nov 6, 2026
d95adb5
gh-161458: Skip test_io.test_free_threading on GIL builds
cmaloney Nov 6, 2026
5d5992a
gh-161458: Remove the test module list from the test_io docstring
cmaloney Nov 6, 2026
03f4f2f
gh-161458: Point to I/O tests outside test_io in its docstring
cmaloney Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions Lib/test/test_io/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,14 @@
Tests are split across multiple files to increase
parallelism and focus on specific implementation pieces.

* test_io
* test_bufferedio - tests file buffering
* test_memoryio - tests BytesIO and StringIO
* test_fileio - tests FileIO
* test_file - tests the file interface
* test_general - tests everything else in the io module
* test_univnewlines - tests universal newline support
* test_largefile - tests operations on a file greater than 2**32 bytes
(only enabled with -ulargefile)
* test_free_threading/test_io - tests thread safety of io objects
Tests for code that uses io live with that code, for example:

* test_capi.test_file - the PyFile_* C API
* test_builtin, test_print - open(), input() and print()
* test_cmd_line, test_subprocess - stdio buffering and newlines at startup
and through pipes
* test_utf8_mode - UTF-8 mode encodings, including with _pyio
* test_os, test_eintr - fd-level I/O and EINTR retries

.. attention::
When writing tests for io, it's important to test both the C and Python
Expand Down
0 Lib/test/test_file_eintr.py → Lib/test/test_io/test_file_eintr.py
View file
Open in desktop
File renamed without changes.
7 changes: 5 additions & 2 deletions Lib/test/test_free_threading/test_io.py → Lib/test/test_io/test_free_threading.py
View file
Open in desktop

@StanFromIreland StanFromIreland Nov 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, don't all free-threading tests live there, I generally thought we keep them there?

@cmaloney cmaloney Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently everything but asyncio. Given free threading is becoming the standard and this has very little "common" free threading needs I'd like if can do next to other module pieces / it's part of what I need to keep working while I modify things..

For this my particular goal is being able to easily go from _io -> [_io, _ionibbler] which is easier to do with them largely in one place. There's currently infra in test_io/utils.py for _pyio vs _io (although I want the _ionibbler to be a little different shape than that if I can)

Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,15 @@
import io
import _pyio as pyio
import threading
from unittest import TestCase
from test.support import threading_helper
from unittest import SkipTest, TestCase
from test.support import Py_GIL_DISABLED, threading_helper
from test.support.threading_helper import run_concurrently
from random import randint
from sys import getsizeof

if not Py_GIL_DISABLED:
raise SkipTest("GIL enabled")

threading_helper.requires_working_threading(module=True)


Expand Down
0 Lib/test/test_winconsoleio.py → Lib/test/test_io/test_winconsoleio.py
View file
Open in desktop
File renamed without changes.
Loading