Skip to content

fix(fullscreen): give native full-screen columns the viewport width - #295

Open
qeude wants to merge 8 commits into
mainfrom
fix/overview-fullscreen-card-aspect
Open

qeude wants to merge 8 commits into
mainfrom
fix/overview-fullscreen-card-aspect

Conversation

@qeude

@qeude qeude commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

Summary

A native full-screen window's card had the column width while its picture was a whole display, and the opening zoom stretched that picture into it. Like Niri, a full-screen window now spans the display: its column spans the viewport, in the strip and in the Overview. The width it had before stays in its placement and comes back on exit.

 normalizeNativeFullscreenColumns (strip)
-  full-screen column keeps the saved width
+  full-screen column: width = .fraction(1); placement keeps the saved width for exit

 logicalOverviewMonitors (Overview)
   column with visible stacked siblings: keeps its own width (unchanged)
-  column re-inserted for full-screen windows only: saved width
+  column re-inserted for full-screen windows only: .fraction(1)

 OverviewSurfaceScene (opening zoom and swipe)
-  picture scaled to the card's shape (stretched when the shapes differ)
+  crop (contentsRect) animated with the size, ending on the card's aspect fill

 OverviewController.chooseSelection
+  a pick on another Space (only possible with native full-screen windows): fade the panels out
+  (Core Animation, 0.16 s, the Overview's 120 Hz preference), keep the session open until the
+  focus commits, close without a zoom

The card then has the picture's shape and uses the same aspect-fill as every other card. It keeps a small crop because the viewport is shorter than the display (menu bar). The opening zoom crops the same way while it scales, so the full-screen picture never stretches; for windows shaped like their card the crop stays the whole picture.

Niri reference: src/layout/scrolling.rs. A full-screen column keeps its stored width; its tile requests the output size (request_fullscreen), and compute_new_view_offset_fit returns 0 for it.

Evidence

Tests (each fails on main and passes here):

  • Entry compacts strip and keeps target after right edge now also expects the full-screen column at .fraction(1). On main it stays .pixels(420). The existing Exit restores exact slot and width without changing selection still passes (.pixels(420) back on exit).
  • New: Logical overview gives a lone fullscreen window the viewport width.
  • make verify passes.

Recording in the defi-e2e VM: the real daemon with Accessibility and Screen Recording granted; TextEdit with the same document tiled (normal.rtf) and in native full screen (full.rtf); the Overview opened from the full-screen Space.

  • Before (main, fd845bc): the full-screen card is column-wide and the display picture is squeezed into it (oval dots, narrow text).
  • After: the full-screen window zooms from the display into a card that spans the workspace width; the picture keeps its proportions (round dots) and the other cards are unchanged. Opening: started(surfaces:2) … completed. In the final pose the dots are round (about 30×30 px; 30×26 before the crop).

The VM recording drops the zoom's first frames for every opening, from the desktop as well, so it shows the end poses, not the smoothness.

Screenshots and recordings are with the maintainer; not attached here.

Not covered: two displays; a full-screen window taken from a stack (its card stays in the stack at the stack's width, unchanged behavior); Computer Use on the installed build.

Picking across Spaces (same VM, Overview opened from the full-screen Space, Left then Return onto the desktop window; a probe logged the panel, active Space and frontmost app every millisecond):

  • Before: the panel stayed on screen through macOS's Space slide and showed on the desktop for about 1.2 s (space=1 with the panel from 4.92 s to 6.19 s).
  • After: the panel fades out by 4.67 s, the Space changes at 4.96 s, no panel on the desktop (2 of 2 runs). A pick on the same Space keeps its timing (panel gone at 6.15 s vs 6.12 s).

Frame pacing on the maintainer's 5K 120 Hz display: Instruments Animation Hitches attached to defi-daemon, six Overview open/close cycles per mode through the CLI. Before this branch's last commit, the first moving frame of the opening zoom rendered the glass and every card for the first time; the glass now renders at alpha 0.002 during the still first pose.

Opening from zoom-start hitch per open, before after all hitches, before → after
native full-screen window 192, 92, 0, 0, 0, 75 ms 0, 83, 0, 0, 0, 0 ms 517 → 125 ms
desktop window maximized to the viewport 0, 225, 83, 108, 50, 42 ms 0, 0, 0, 67, 0, 0 ms 833 → 225 ms
desktop (alternating A/B, two rounds) 400, 1192 → 292, 342 ms

Closes from full screen: 6/6 without hitches. The fade before a Space slide drops 1-2 frames (8-25 ms) in 4 picks; later hitches in those picks fall in macOS's own Space slide. Zoom landing (+280 ms): the panel window turned opaque there while on screen. Keeping it non-opaque (same change as #296, folded in here) removed the landing hitch: 8 of 12 opens dropped 1-2 frames there before, 0 of 12 after (desktop, alternating A/B, two rounds; totals 412, 262 → 321, 233 ms). A 1-3 frame hitch at the very start of a close from the desktop remains in both builds; closes from full screen were clean.

Cadence at this head (share of frame-to-frame steps within one 120 Hz refresh, 8.3 ms, during each animation; six cycles per mode): strip navigation, the baseline, 93%; Overview close 95% (desktop) and 98% (full screen); open 83% (desktop) and 87% (full screen), the gap being one stall at the very start of the zoom; fade before a Space slide 87%.

Merge Danger

Door: two-way

Blast Radius: native full-screen columns

In the strip, the full-screen placeholder now spans the viewport when navigated to, instead of keeping the column width. Width commands on that column do not stick while it is full screen. The width comes back on exit.

Closes #289

A native full-screen window's card has the column width, while its picture
is a whole display. The opening zoom scaled that picture non-uniformly into
the card and left it there, so the preview looked squeezed.

Full-screen windows no longer zoom from the desktop, which they are not on,
and their card draws the picture aspect-fit, centred over the card's
background, with the title above and the Full Screen label below.

Closes #289
@github-actions github-actions Bot added the macroscope-review Request a Macroscope review label Nov 15, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Approvability

Verdict: Approved at 11e57d4

Macroscope's review found this PR approvable — Full-screen columns now span the viewport, with proportional Overview previews and smoother transitions between Spaces. The changes are limited to local layout and presentation, while saved widths remain available for restoration.

You can add or adjust custom eligibility rules. Learn more.

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Nov 15, 2026
Like Niri, a full-screen window spans the display, so its column now spans
the viewport in the strip and in the Overview, while the placement keeps the
width it returns to on exit. The Overview card then has the picture's shape
and uses the same aspect-fill as every other card, so the letterbox is gone.
A column that still holds visible stacked windows keeps its own width.

Refs #289
@macroscopeapp
macroscopeapp Bot dismissed their stale review November 15, 2026 12:03

Dismissing prior approval to re-evaluate f2f3c94

@qeude qeude changed the title fix(overview): keep full-screen cards at the picture's aspect ratio fix(fullscreen): give native full-screen columns the viewport width Nov 15, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Nov 15, 2026
Its card now spans the viewport, so the picture zooms in without stretching.
Skipping it left no visible anchor when the Overview opened from the full-screen
Space, and the opening fell back to a fade.
@macroscopeapp
macroscopeapp Bot dismissed their stale review November 15, 2026 13:55

Dismissing prior approval to re-evaluate c2c3938

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Nov 15, 2026
…ing it

A full-screen window's card is shaped unlike the display, so scaling the
picture to it squeezed the content, and the zoom layer stays over the card.
The zoom now animates the crop with the size and ends on the card's aspect fill.
@macroscopeapp
macroscopeapp Bot dismissed their stale review November 15, 2026 16:08

Dismissing prior approval to re-evaluate 45c755f

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Nov 15, 2026
Choosing a window on another Space, such as a desktop window from a native
full-screen Space, made macOS slide while the Overview stayed open until the
focus committed: it vanished on one side and showed again on the destination
for about a second. The panels now hide at once and the close skips the zoom.
@macroscopeapp
macroscopeapp Bot dismissed their stale review November 15, 2026 19:07

Dismissing prior approval to re-evaluate ec7a58a

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Nov 15, 2026
Hiding the panels at once cut the transition to zero frames. The panel now
fades with Core Animation at the Overview's 120 Hz preference, like its other
transitions, then orders out.
@macroscopeapp
macroscopeapp Bot dismissed their stale review November 15, 2026 19:41

Dismissing prior approval to re-evaluate 1087569

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Nov 15, 2026
The glass and its cards stayed at alpha 0 until the zoom moved, so its first
moving frame paid for the 5K glass, every card picture and their textures at
once: 75-225 ms on a 120 Hz display for a full-screen or maximized window.
At alpha 0.002 they render while the first pose, which matches the desktop,
is on screen.
@macroscopeapp
macroscopeapp Bot dismissed their stale review November 15, 2026 20:25

Dismissing prior approval to re-evaluate 4fd9290

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Nov 15, 2026
Turning the panel window opaque at the end of the opening zoom and back at
closing, while it is on screen, let a frame show the windows beneath, and cost
one or two frames at the zoom's landing on a 120 Hz display (8 of 12 opens).
The window stays non-opaque; its layers still paint the backing and wallpaper.

Same change as #296.
@macroscopeapp
macroscopeapp Bot dismissed their stale review November 15, 2026 20:41

Dismissing prior approval to re-evaluate 11e57d4

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macroscope-review Request a Macroscope review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Full-screen cards appear distorted in the Overview

1 participant