Skip to content

fix(overview): keep the panel non-opaque so closing never flashes - #296

Open
qeude wants to merge 1 commit into
mainfrom
fix/overview-close-flash
Open

qeude wants to merge 1 commit into
mainfrom
fix/overview-close-flash

Conversation

@qeude

@qeude qeude commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

Summary

Closing the Overview opened from a native full-screen window could blink: for a frame or a few, the full-screen window showed through the panel, then the closing zoom resumed over the wallpaper.

 OverviewPanel.uncoverChrome (end of the opening zoom)
-  window.isOpaque = hasWallpaper; backgroundColor = black
+  window stays non-opaque (its layers still paint the black backing and wallpaper)

The closing zoom installs the menu bar and Dock mask and needs a non-opaque window. Flipping isOpaque back to false on a window already on screen let one frame through. From the desktop that frame shows the desktop, so nobody saw it.

Evidence

In the defi-e2e VM: real daemon, Accessibility and Screen Recording granted, TextEdit in native full screen. Each trial opens the Overview from the full-screen Space and closes it while screencapture -v records. A flash is a frame of the window between frames of the Overview, found by measuring the luma of a screen corner.

  • Probe: the panel (layer 25) stays on screen through the whole close; the active Space and frontmost app never change. So this is not a Space switch or an activation.
  • Before (main and fix(fullscreen): give native full-screen columns the viewport width #295's base): flashes in 3 of 7 readable recordings (3 more recordings failed when screencapture hung).
  • After: 0 of 8.
  • make verify passes.

Not covered: two displays; Computer Use on the installed build; a cost measurement of the non-opaque window (it was already non-opaque while chrome is uncovered and without a captured wallpaper).

Merge Danger

Door: two-way

Blast Radius: Overview panel compositing

The open panel is now composited as non-opaque. Its content is still opaque, so nothing should show through.

Note

Remove opacity changes from OverviewPanel.uncoverChrome to fix close flash

uncoverChrome in OverviewPanel.swift no longer checks for a captured desktop or toggles the panel's opacity and background color. It still clears the chrome mask and commits the Core Animation transaction. The window now stays non-opaque, so closing the panel no longer flashes.

Macroscope summarized 690609d.

Turning the panel window opaque after the opening zoom and back at closing,
while it is on screen, let one frame show the windows beneath. Over a native
full-screen window that frame is the window itself, so the Overview blinked.
@github-actions github-actions Bot added the macroscope-review Request a Macroscope review label Nov 15, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 15, 2026

Copy link
Copy Markdown

Approvability

Verdict: Approved at 690609d

Macroscope's review found this PR approvable — This keeps Overview non-opaque after its opening transition to prevent a closing flash, while preserving its backing layers. The change is confined to local rendering, with recorded full-screen trials supporting the intended improvement.

Notes:

  • Macroscope's correctness review did not run, so approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

qeude added a commit that referenced this pull request Nov 15, 2026
Turning the panel window opaque at the end of the opening zoom and back at
closing, while it is on screen, let a frame show the windows beneath, and cost
one or two frames at the zoom's landing on a 120 Hz display (8 of 12 opens).
The window stays non-opaque; its layers still paint the backing and wallpaper.

Same change as #296.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macroscope-review Request a Macroscope review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant