Repository navigation
Conversation
Turning the panel window opaque after the opening zoom and back at closing, while it is on screen, let one frame show the windows beneath. Over a native full-screen window that frame is the window itself, so the Overview blinked.
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This keeps Overview non-opaque after its opening transition to prevent a closing flash, while preserving its backing layers. The change is confined to local rendering, with recorded full-screen trials supporting the intended improvement. Notes:
You can add or adjust custom eligibility rules. Learn more. |
qeude
added a commit
that referenced
this pull request
Nov 15, 2026
Turning the panel window opaque at the end of the opening zoom and back at closing, while it is on screen, let a frame show the windows beneath, and cost one or two frames at the zoom's landing on a 120 Hz display (8 of 12 opens). The window stays non-opaque; its layers still paint the backing and wallpaper. Same change as #296.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closing the Overview opened from a native full-screen window could blink: for a frame or a few, the full-screen window showed through the panel, then the closing zoom resumed over the wallpaper.
The closing zoom installs the menu bar and Dock mask and needs a non-opaque window. Flipping
isOpaqueback to false on a window already on screen let one frame through. From the desktop that frame shows the desktop, so nobody saw it.Evidence
In the
defi-e2eVM: real daemon, Accessibility and Screen Recording granted, TextEdit in native full screen. Each trial opens the Overview from the full-screen Space and closes it whilescreencapture -vrecords. A flash is a frame of the window between frames of the Overview, found by measuring the luma of a screen corner.mainand fix(fullscreen): give native full-screen columns the viewport width #295's base): flashes in 3 of 7 readable recordings (3 more recordings failed whenscreencapturehung).make verifypasses.Not covered: two displays; Computer Use on the installed build; a cost measurement of the non-opaque window (it was already non-opaque while chrome is uncovered and without a captured wallpaper).
Merge Danger
Door: two-way
Blast Radius: Overview panel compositing
The open panel is now composited as non-opaque. Its content is still opaque, so nothing should show through.
Note
Remove opacity changes from
OverviewPanel.uncoverChrometo fix close flashuncoverChromein OverviewPanel.swift no longer checks for a captured desktop or toggles the panel's opacity and background color. It still clears the chrome mask and commits the Core Animation transaction. The window now stays non-opaque, so closing the panel no longer flashes.Macroscope summarized 690609d.