Repository navigation
chore: bump go directive to 1.26.10 (clears reachable stdlib vulns) - #67
Merged
Merged
Conversation
govulncheck on the security workflow was flagging GO-2026-6809 (crypto/x509), GO-2026-6617 (net/http), and GO-2026-6613 — all reached via auth.Login / http.Client.Do and all fixed in the Go 1.26.9/1.26.10 stdlib. Bumping the go directive lets setup-go pull a patched toolchain in CI; no source changes needed. Same fix pattern as #47/#62. Co-Authored-By: Paperclip <noreply@paperclip.ing>
Contributor
Try this PR without building itReview binaries for commit
Unzip, then on macOS/Linux Links are resolved by nightly.link, a third-party redirector for GitHub Actions artifacts, because GitHub has no anonymous artifact URL of its own. Signed-in users can also browse the run directly. Artifacts expire 14 days after the run. Updated on each push to this PR. |
DTTerastar
approved these changes
Nov 3, 2026
DTTerastar
pushed a commit
to quantcli/crono-export-cli
that referenced
this pull request
Nov 3, 2026
) govulncheck flagged 10 reachable stdlib vulnerabilities on the 1.26.8 toolchain (net/http and crypto/x509, reached via cronoapi.Client and cmd.Execute). Bumping the go directive to 1.26.10 lets setup-go pull a patched toolchain in CI; no source changes needed. Same fix pattern as quantcli/liftoff-export-cli#67. Co-authored-by: Terastar-Paperclip <noreply@paperclip.ing>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
securityworkflow's govulncheck job fails on main's current toolchain (Go 1.26.8), flagging stdlib vulnerabilities our code actually reaches viaauth.Login/http.Client.Do:crypto/x509), fixed in go1.26.10net/http), fixed in go1.26.9What changed
Bumped the
godirective ingo.modfrom1.26.8to1.26.10. CI usesgo-version-file: go.modeverywhere, so no workflow file changes are needed —setup-gowill pull the patched toolchain automatically.Verification
go build ./...— passes (toolchain auto-downloads go1.26.10 locally too)go vet ./...— cleango test ./...— passesgovulncheck ./...— No vulnerabilities found (previously flagged the three CVEs above)Same fix pattern as #47 and #62.
QUA-65