Repository navigation
refactor(cli): remove test-only diarization wrappers - #2389
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove three diarization windowing wrappers on the command types that were referenced only by a test. That test now checks the canonical windowing provider directly against explicit app-tuned defaults and the 1431/1903 window-count cases. Production diarization configuration and CLI commands are unchanged.
Validation: all 11 mapped checks passed, including the full CLI suite (149 tests) and packaging/manifest controls. Focused diarization tests passed in retrieval (10), audio (11), and meeting-import (13) modes.
verify-change.shapplies no app check; no models, capture devices or real library were used. Independent full diff review: GREEN, no findings.Completes the remaining wrapper portion of TOOLS-CLI-12. The RTTMWriter.write and Batch unused-total removals are already pending in #2336; they are not duplicated here and are not described as landed.