Skip to content

refactor(cli): remove test-only diarization wrappers #2389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r3dbars merged 1 commit into from
Nov 12, 2026
Merged

refactor(cli): remove test-only diarization wrappers #2389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions Tools/TranscriptedCLI/Sources/TranscriptedCLI/CLIDiarization.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,15 +229,3 @@ enum CLIDiarization {
FileHandle.standardError.write(Data((note + "\n").utf8))
}
}

extension ImportAudio {
static var sharedDiarizationWindowing: CLIDiarization.Windowing { CLIDiarization.windowing }
}

extension Diarize {
static var sharedDiarizationWindowing: CLIDiarization.Windowing { CLIDiarization.windowing }
}

extension Batch {
static var sharedDiarizationWindowing: CLIDiarization.Windowing { CLIDiarization.windowing }
}
7 changes: 2 additions & 5 deletions Tools/TranscriptedCLI/Tests/TranscriptedCLITests/CLIDiarizationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,11 +198,8 @@ final class CLIDiarizationTests: XCTestCase {
)
}

func testEveryCLIPathSharesTheAppTunedPyannoteWindowing() {
XCTAssertEqual(ImportAudio.sharedDiarizationWindowing, Diarize.sharedDiarizationWindowing)
XCTAssertEqual(Diarize.sharedDiarizationWindowing, Batch.sharedDiarizationWindowing)

let windowing = Diarize.sharedDiarizationWindowing
func testDefaultWindowingUsesTheAppTunedPyannoteSchedule() {
let windowing = CLIDiarization.windowing
XCTAssertEqual(windowing.windowDuration, 10.0)
XCTAssertEqual(windowing.segmentationStepRatio, 0.266, accuracy: 1e-12)
XCTAssertEqual(windowing.nemotronSliceSeconds, 10.0)
Expand Down
Loading