Repository navigation
docs: include Writing in the diagnostic sink map - #2419
Merged
Merged
Conversation
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The observability inventory omits Writing’s
DiagnosticsLog. Add its source location, defaultwriting-diagnostics.logpath and existing 4 MB / one.1generation rotation, then update the documented sink count from five to six.Verified against the full logger implementation and the storage map. This records existing behavior; it changes no logger, payload, retention setting or privacy policy. AppLogSink and feedback documentation corrections are outside this PR.
Validation on
e26d8a887: all three mappedbash check.shdocumentation checks passed; preflight passed;verify-change.shreported no applicable app check. Independent full two-hunk diff/source review againstorigin/main: GREEN from the coordinator before commit. No logger instantiation/runtime or real log reads.This extracts only DOCS-19’s sink inventory correction from broad pending #2336, which remains untouched and unmerged. Preserve its unrelated hunks and apply this portion once during integration. No merge requested.