Repository navigation
docs: align fast runner comments with cache behavior - #2448
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the obsolete stable-runner-path rationale, match the stale-lock comment to the actual 60-minute threshold, and describe cached object output by
APP_SOURCESmembership instead of a stale literal count. Executable runner logic and source lists are unchanged.This extracts only TESTS-INFRA-11's three factual comments from broad pending #2336. Its unrelated source-list addition is excluded, and #2336 stays unchanged. Independent full-diff and owning-source review: GREEN before commit. The mapped Python completion-contract tests and their fixed fake-child/owned-temp helpers also received source-safety review before execution.
Validation at bfc3b9b: five mapped checks PASS, including shell syntax, build-source inventory, source pins, and the Python completion contracts. Actual fast tests were explicitly BLOCKED (exit 3) by the reviewed invocation guard, so canonical deterministic proof remains FAIL. Stable, clean exact-head receipt archived. Standalone preflight passed;
verify-change.shselected no app checks. No Swift test runner, app, native/model, preferences, microphone, or user-profile runtime was executed.Also covers BUILD-CI-14: the same stale cache-lock timeout comment reported as TESTS-INFRA-11. These are two report IDs for one correction.