Skip to content

refactor(meeting): remove unused snooze wrapper - #2516

Merged
r3dbars merged 1 commit into
mainfrom
codex/review-meeting-a-2
Nov 12, 2026
Merged

r3dbars merged 1 commit into
mainfrom
codex/review-meeting-a-2

Conversation

@r3dbars

@r3dbars r3dbars commented Nov 10, 2026

Copy link
Copy Markdown
Owner

Addresses MEETING-A-2.

Remove the unused internal MeetingPromptDetector.snooze(candidate:interval:) wrapper. No production, test, method-value or selector caller references it. The actual Not now and Remind actions already call dismiss(candidate:) and remindSoon(candidate:); Record and both active backoff paths remain unchanged.

The owner guide now names those actual calls, and the detection spec drops the dead API from its list. The full backoff file is byte-identical to main after removing only this seven-line wrapper. Both suppressRuntimePrompts overloads remain; MEETING-A-3 is separate. This is an issue-sized extraction of the same cleanup proposed in broad draft #2336, without adopting its other changes.

Validation at 3c3a08d69d0647b02582d5084ac4d621763e97b5:

  • Independent full three-file diff, caller/API and protected-flow review: GREEN. The detector is an internal Swift class, with no Objective-C export of this method. App callbacks and prompt wiring are byte-identical to main.
  • No new test is needed for unreachable-wrapper removal. Existing heuristic snooze/cooldown tests and concepts remain unchanged; the mixed prompt suite was not executed on the owner profile.
  • Guarded bash check.sh: 18 PASS, including forced dependencies, the actual app build and concurrency census; one orchestration SKIPPED entry and full fast/integration suites deliberately blocked (each exit 3), so overall canonical proof remains FAIL. The exact-head stable/clean raw JSON was archived before verification.
  • Standalone preflight PASS. verify-change.sh exits 0 with meetings SKIP because Transcripted is already running; the owned app builds, but no app is quit or launched. Its generic live-hardware advisory remains unknown. Full QA bench is blocked at its outer invocation (exit 3), not run.

No prompt policy or user-facing Record / dismiss / remind surface changes. Native meeting detection and hardware behavior are not claimed verified by this cleanup.

@r3dbars
r3dbars merged commit 32e765c into main Nov 12, 2026
18 of 22 checks passed
@r3dbars
r3dbars deleted the codex/review-meeting-a-2 branch November 12, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant