Repository navigation
refactor(meeting): remove unused snooze wrapper - #2516
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses MEETING-A-2.
Remove the unused internal
MeetingPromptDetector.snooze(candidate:interval:)wrapper. No production, test, method-value or selector caller references it. The actual Not now and Remind actions already calldismiss(candidate:)andremindSoon(candidate:); Record and both active backoff paths remain unchanged.The owner guide now names those actual calls, and the detection spec drops the dead API from its list. The full backoff file is byte-identical to main after removing only this seven-line wrapper. Both
suppressRuntimePromptsoverloads remain; MEETING-A-3 is separate. This is an issue-sized extraction of the same cleanup proposed in broad draft #2336, without adopting its other changes.Validation at
3c3a08d69d0647b02582d5084ac4d621763e97b5:bash check.sh: 18 PASS, including forced dependencies, the actual app build and concurrency census; one orchestration SKIPPED entry and full fast/integration suites deliberately blocked (each exit 3), so overall canonical proof remains FAIL. The exact-head stable/clean raw JSON was archived before verification.verify-change.shexits 0 with meetings SKIP because Transcripted is already running; the owned app builds, but no app is quit or launched. Its generic live-hardware advisory remains unknown. Full QA bench is blocked at its outer invocation (exit 3), not run.No prompt policy or user-facing Record / dismiss / remind surface changes. Native meeting detection and hardware behavior are not claimed verified by this cleanup.