Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TESTS-FAST-4: replace 100
assertionFailurecalls across nine fast-test files with the existingassertTrue(false, ...)helper. A failed check now records a suite-attributed failure so the runner can report it. All 35 protective returns and surrounding control flow remain unchanged. This extracts only this issue’s hunk from broad draft #2336; TESTS-FAST-5 remains separate.Independent full-diff review against fetched
origin/main: GREEN (Infra and coordinator). Exact nine-file owner-credited commit:b72a7bf7491378db87dd32dfe8de32a56bc6e0e1. Reviewed source and proof hashes were associated with the committed blobs. The assertion helper and its counters are unchanged; no new thread-safety claim.Validation:
TestHelpers.swiftwith a frozen entry point: three checks, one pass and two intentional recorded failures, with both suite attributions present. The guarded path returned safely; the caught-error path and later suite continued. Zero quarantined checks or metadata violations.bash check.sh: nine PASS, one FAIL (the full fast suite was explicitly refused with exit 3). The owned app build and eight static checks passed. Overall canonical result remains FAIL.The 100 actual storage/preferences branches were not executed. No full fast suite,
--list, native capture, real preference behavior or hardware proof is claimed. The synthetic proof verifies helper recording and continuation, not every changed branch. Combined CI and owner review are still required before merge.