Skip to content

test(coordinator): repair native takeover synchronization and retain qualification evidence - #160

Closed
rabii-chaarani wants to merge 3 commits into
mainfrom
docs/cod52-cod98-native-evidence
Closed

rabii-chaarani wants to merge 3 commits into
mainfrom
docs/cod52-cod98-native-evidence

Conversation

@rabii-chaarani

@rabii-chaarani rabii-chaarani commented Oct 27, 2026 •

Copy link
Copy Markdown
Owner

COD-109 / GH-160 — repair failed native integration fixture

Fixes the demonstrated missing terminal-worker precondition before the first abrupt coordinator takeover. Only tests/coordinator_process.rs changes executable/test behavior. Actual worker/writer and registered root-owner observation leases remain held through kill/wait; strict pending-intent, receipt, resource, publication and takeover assertions stay unchanged. No runtime/public contract, resource constant, timeout, workflow or dependency changes.

  • COD-109, Scryer chg-n2nnjh; current user authorizes repair + merge after gates, not release/deployment.
  • Canonical bounded repair and evidence.
  • Fresh GPT-6.1 Sol/High proposal and Sol/Max final review cleared exact source SHA256 d3dd06523d1ebc4250820770bb99a3c03a664e99a2870d4c66edf9351a80657a, integrated with main 5889ed09954a4a07efd2590dd1bd380ee77be06a.
  • Independent local macOS: 5/5 selected native cases passed first execution, no retries; 22 other cases filtered, not executed. Real-lock helper, coordinator takeover and three existing active owner-loss/cancellation/unknown-containment cases executed. Formatting and strict workspace/all-target/all-feature Clippy pass, no warnings.
  • Final-head full hosted native CI, no-bypass merge and actual main-SHA CI remain pending. Original CI pending-intent failure and local false-empty/EPERM baseline remain distinct and preserved; no claim their exact low-level causes are identical.
  • Reuses canonical worker-recovery/disk-cleanup contracts. Unchanged historical approvals are not advanced. A raw nextest log remains byte-exact, including its final blank line; scoped whitespace check excludes only that raw-output path.

Preserved historical COD-52 / COD-98 qualification

This PR also retains the original exact-head evidence for CI40457158678, 22/22 jobs passed, implementation head 5e3e42f48a55581ef75b25ba21732913089f664d, tree-identical tested synthetic merge f61579940edfa3f3bf67ac6b2e7abbf04ea37cfb. Historical canonical report remains unchanged; it does not qualify this new head.

  • COD-52: CBG-PLAT-01 rev0.10 SHA 1a9db7b558b60248888408daa6268a3b45f2f0df, R01/A01–A02; unchanged approval.
  • COD-98: existing CBG-COPY-01 A3/A9; unchanged process-identity test approval.
  • Historical Windows warnings, incomplete old local run, unknown old PID cause, minimum/current clean-consumer/COD-61 and aggregate closure limits remain explicit. No publication, deployment or aggregate closure follows from this PR.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T07:23:18.752741Z 156cbd3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@rabii-chaarani
rabii-chaarani added this pull request to stack #161 October 27, 2026 07:33
@rabii-chaarani
rabii-chaarani force-pushed the docs/cod52-cod98-native-evidence branch 3 times, most recently from e416598 to 1b8c875 Compare October 28, 2026 04:49
Base automatically changed from fix/cod-52-macos-nested-scans to main October 28, 2026 04:53
@rabii-chaarani
rabii-chaarani force-pushed the docs/cod52-cod98-native-evidence branch from 1b8c875 to 9a01666 Compare October 28, 2026 04:53
@rabii-chaarani
rabii-chaarani force-pushed the docs/cod52-cod98-native-evidence branch from 9a01666 to 12fdbb2 Compare October 29, 2026 05:14
Fix COD-109 / GH-160 within existing worker-recovery contracts.
Current user approved fixing PR 160 and merging it after applicable gates.
Retain real execution and workspace-owner observation leases across the
first abrupt coordinator exit; preserve strict terminal-control predicates.

Reuse canonical worker-recovery and graph disk-cleanup contracts;
CBG-PLAT-01 and CBG-COPY-01 historical approvals remain unchanged.
Record proposal/final review and exact-source local verification under
docs/specs/CBG-PLAT-01/execution/pr160-ci-repair.md.

Verification: five selected native macOS cases passed first execution,
zero retries; 22 other cases filtered. Formatting and strict locked
workspace/all-target/all-feature Clippy passed with no warnings.
Hosted final-head CI and main-SHA CI remain pending. No release.
@rabii-chaarani rabii-chaarani changed the title docs(test): record passing native verification for COD-52 and COD-98 test(coordinator): repair native takeover synchronization and retain qualification evidence Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant