docs: name implementation in the NewClone determinant set

[thedavidmeister]

Closes #135

The NewClone note said sender "is not part of the address derivation, but
salt and data together are the whole of it". The antecedent of "it" is the
address derivation, and salt + data are not the whole of it. The address is
keccak256(0xff ++ factory ++ effectiveOpenSalt(salt, keccak256(data)) ++ keccak256(cloneCreationCode(implementation))), so implementation — a
caller-supplied argument of cloneDeterministicOpenSalt, not a fixed property of
the factory — is a third input. salt and data are the whole of the EFFECTIVE
SALT only, which the same paragraph's neighbour at :92 already says.

The file states the correct set two hundred lines earlier (:98-99, "a pure
function of (factory, implementation, salt, data)"), so the interface
contradicted itself in the passage an indexer reads when deciding which event
fields reconstruct the address. The conclusion drawn from it held only because
NewClone happens to carry implementation as well — which the corrected
sentence now says.

factory stays implicit, matching the house phrasing on
ICloneableFactoryV3.NewClone: the emitter is the factory.

Comment-only. No source, ABI or bytecode change.

QA

• Discriminating tests: n/a — comment-only change; tests never assert NatSpec
  text.
• Mutations applied: n/a — no executable src line changes, so there is nothing
  to mutate.
• Oracle: src/lib/LibICloneableFactoryV4.sol:116-128
  (predictCloneAddress hashes keccak256(cloneCreationCode(implementation))
  into the preimage) and ICloneableFactoryV3.sol:38, whose NewClone signature
  carries implementation.
• Category check: the category is "determinant set stated with implementation
  dropped". Sibling instances in this file are filed separately — [F64] [LOW] Namespaced bullet says the address "does not commit to WHAT was deployed", but implementation is in the CREATE2 preimage on both derivations #168 (the
  namespaced comparison bullet) and [F21] [LOW] ICloneableFactoryV4's NatSpec is a multi-section essay that re-teaches CREATE2, front-running and Zoltu deploys #125's cross-network paragraph. NewClone's V3 NatSpec calls the clone address a pure function of (implementation, sender, salt), which is false on the open-salt derivation #79 quoted the
  same shape but was closed not-planned because it sat in the deprecated
  ICloneableFactoryV3, which is frozen.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

Next included review available in 41 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 34a640bf-41be-48ed-91b6-c11ac05ec809

📥 Commits

Reviewing files that changed from the base of the PR and between 710dff5 and ab7ad07.

📒 Files selected for processing (1)

• src/interface/ICloneableFactoryV4.sol

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}