Skip to content

docs: name implementation in the NewClone determinant set #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thedavidmeister wants to merge 3 commits into
base: main
Choose a base branch
from
Open

docs: name implementation in the NewClone determinant set #244

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8cb0eb9
docs: name `implementation` in the `NewClone` determinant set
claude Sep 21, 2026
0508343
Merge remote-tracking branch 'origin/main' into 2026-09-21-issue-135-…
thedavidmeister Sep 21, 2026
ab7ad07
docs: rewrap the Events note
claude Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/interface/ICloneableFactoryV4.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,12 +196,12 @@ interface ICloneableFactoryV4 is ICloneableFactoryV3 {
/// `NewClone` is shared with `cloneDeterministic` and is emitted
/// identically, with the caller-supplied `salt` — NOT the effective salt.
/// Its `sender` field is only whoever paid for this deploy and is not part
/// of the address derivation, but `salt` and `data` together are the whole
/// of it, so the event still carries the full deterministic deploy that
/// `ICloneableFactoryV3.NewClone` promises. An indexer that wants to verify
/// the address rather than take the emitted one MUST pick the derivation:
/// the two cannot both produce the emitted `clone`, so trying both and
/// keeping the match is well defined.
/// of the address derivation, but `implementation`, `salt` and `data` — all
/// on the event — are the whole of it, so it still carries the full
/// deterministic deploy that `ICloneableFactoryV3.NewClone` promises. An
/// indexer that wants to verify the address rather than take the emitted
/// one MUST pick the derivation: the two cannot both produce the emitted
/// `clone`, so trying both and keeping the match is well defined.
///
/// @param implementation The contract to clone.
/// @param data As per `ICloneableV2`, and part of the address derivation.
Expand Down
Loading