Repository navigation
fix(assistant): make history actions visibly interactive - #287
Merged
Merged
Conversation
Deploying document with
|
| Latest commit: |
1200259
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c79a4c46.document-7hm.pages.dev |
| Branch Preview URL: | https://codex-history-action-afforda.document-7hm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
History & data commands looked like plain text until hover. They now have visible secondary button surfaces, a separate destructive group, and a visually distinct explicit-deletion confirmation.
Merge Verdict
[APPROVE]
Independent review approved the final follow-up after an outline-delete contrast finding was fixed. The change is limited to history-control grouping and appearance, with rendered regressions for the winning cascade and native interaction paths.
Summary
Risk Analysis
Design Decisions
66a00775using existing foundation/application tokens and the installed ranui builder.Code Concerns
No unresolved findings in the scoped code review. Pre-PR review reproduced light-theme outline-delete hover/pressed contrast below AA; the fix now independently measures 5.04:1 / 5.43:1 in light and 5.62:1 / 5.29:1 in dark for both deletion controls.
Verification
PromiseRejectionHandledWarningmessages.Final-head remote acceptance
All workflows below passed on
12002592d95423f288cf2aa7ebf0c9e62ee7049b; all four commits are pushed.Cache-Control: no-storeAll eight distinct browser reports were uploaded. The weekly external-document corpus was explicitly excluded from this focused UI/browser validation. No main/preview/nightly job or workflow was rerun on this head, and no timeout, worker, retry, skip or assertion policy was relaxed.
Existing retry observations
These workflow results are not zero-retry nightly results. Three unchanged tests passed their configured first retry; their original observations are retained in the linked nightly logs and artifacts:
agent-composer-ux.spec.ts:153: historical reading position changed after editing the next draft (scrollTop1293 instead of 0).agent-sources-artifacts.spec.ts:136: the reference-preview summary detached during a click after search, exhausting the existing test timeout.save-to-file.spec.ts:289: initial text insertion was not observed within the existing five-second assertion, before the held-conversion fault was installed.No added history-action regression required a retry.
Conclusion basis: verified through the commands and rendered interactions above, plus caller/selector tracing. Main CI, real deployed-preview smoke and the complete nightly browser/budget workflow passed on the pushed head; remaining pre-existing nightly flakiness is disclosed above, and the unrelated weekly corpus matrix is outside this UI change.