Repository navigation
Overlap simulator boot with the rest of the iOS E2E setup - #59640
Open
cipolleschi wants to merge 1 commit into
Open
cipolleschi wants to merge 1 commit into
cipolleschi wants to merge 1 commit into
Conversation
The iOS E2E action did all of its setup one step after another before touching the simulator. `xcrun simctl install` then waited ~2 minutes for the simulator to finish booting. - Start booting the simulator as the first step (new `boot` subcommand of maestro-ios.js), so it boots while Maestro, Java, the node modules and Metro are being set up. - Drop the `idb-companion` install. Maestro removed its IDB dependency on iOS in 1.x (see "Removed IDB on iOS" in its changelog) and 2.6.1 doesn't reference it. - Drop the second Node.js setup: both callers (RNTester and the template app) already set up Node.js before using the action.
This was referenced Oct 29, 2026
meta-cla
Bot
added
the
CLA Signed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack (iOS RNTester E2E cost, review bottom-up):
Summary:
Part 6 of the iOS E2E cost stack.
The iOS E2E action ran all of its setup one step after another before touching the simulator, and
xcrun simctl installthen waited ~2 minutes for the simulator to finish booting.bootsubcommand ofmaestro-ios.js, which picks the simulator the same way as the test step). It then boots while Maestro, Java, the node modules and Metro are set up.brew install idb-companionstep (~16s). Maestro removed its IDB dependency on iOS in 1.x ("Removed IDB on iOS" in its changelog), and nothing in the 2.6.1 sources references it.Changelog:
[INTERNAL] [CHANGED] - Overlap simulator boot with the rest of the iOS E2E setup
Test Plan:
node .github/workflow-scripts/maestro-ios.js boot <model> <os>locally: picks the configured simulator, boots it and returns. It accepts an already-booted simulator and auto-selects when given empty arguments, like the template app does.yarn jest .github/workflow-scripts/__tests__/maestro-ios-test.jspasses.Installing app.