Repository navigation
Fail iOS RNTester E2E straight away when the app artifact is missing - #59641
Open
cipolleschi wants to merge 1 commit into
Open
cipolleschi wants to merge 1 commit into
cipolleschi wants to merge 1 commit into
Conversation
test_e2e_ios_rntester only checks that test_ios_rntester succeeded, but test_ios_rntester uses continue-on-error, so it reports success even when the leg that uploads RNTesterApp-NewArch-<flavor> failed. In run 40709683649 the Release app was never uploaded and the E2E job still started (and retried) three times. Download the app as the first step after checkout, and treat a missing app as a non-retryable failure with an error that points to the build job, instead of an incomplete run that triggers the workflow retries.
This was referenced Oct 29, 2026
meta-cla
Bot
added
the
CLA Signed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack (iOS RNTester E2E cost, review bottom-up):
Summary:
Part 7 of the iOS E2E cost stack.
test_e2e_ios_rntesteronly checks thattest_ios_rntestersucceeded, buttest_ios_rntesterusescontinue-on-error, so it reports success even when the leg that uploadsRNTesterApp-NewArch-<flavor>failed (the upload is its last step). In run 40709683649 the Release app was never uploaded and the E2E job still started, and retried, three times.Download the app as the first step after checkout, and treat a missing app as a non-retryable failure with an error that points to the build job, instead of an incomplete run that triggers the workflow retries.
Gating in
test-all.ymlon the artifact itself would needactions: readto list artifacts, which the reusable workflow can't get under Test All'scontents: read.Changelog:
[INTERNAL] [CHANGED] - Fail iOS RNTester E2E straight away when the app artifact is missing
Test Plan:
actionlintreports no new issues.download-artifactfails after its 3 attempts, the job is classifiedfailed, and the run fails without workflow retries.