Skip to content

Fail iOS RNTester E2E straight away when the app artifact is missing #59641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cipolleschi wants to merge 1 commit into
base: cipolleschi/e2e-ios-6-overlap-setup
Choose a base branch
from
Open

Fail iOS RNTester E2E straight away when the app artifact is missing #59641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions .github/workflows/e2e-ios-rntester.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,9 @@ jobs:
SHOULD_RUN=false
fi
echo "should-run=$SHOULD_RUN" >> "$GITHUB_OUTPUT"
- name: Setup Node.js
if: steps.test-state.outputs.should-run == 'true'
uses: ./.github/actions/setup-node
# First, so that a missing app fails the job before any other setup.
- name: Download App
id: download-app
if: steps.test-state.outputs.should-run == 'true'
uses: ./.github/actions/download-artifact
with:
Expand All @@ -64,6 +63,9 @@ jobs:
- name: Check downloaded folder content
if: steps.test-state.outputs.should-run == 'true'
run: ls -lR /tmp/RNTesterBuild
- name: Setup Node.js
if: steps.test-state.outputs.should-run == 'true'
uses: ./.github/actions/setup-node
- name: Run E2E Tests
id: run-tests
if: steps.test-state.outputs.should-run == 'true'
Expand Down Expand Up @@ -95,14 +97,19 @@ jobs:
if: always()
shell: bash
# passed: every flow passed.
# failed: a flow failed all of its attempts; retrying the job would only
# repeat the same failure.
# failed: a flow failed all of its attempts, or the app to test is
# missing; retrying the job would only repeat the same failure.
# incomplete: the job stopped before running every flow (runner or
# setup failure); a retry can pick up the remaining flows.
run: |
STATE=/tmp/maestro-ios-state/results.json
if [[ "${{ steps.test-state.outputs.should-run }}" == "false" || "${{ steps.run-tests.outcome }}" == "success" ]]; then
RESULT=passed
elif [[ "${{ steps.download-app.outcome }}" == "failure" ]]; then
# test_ios_rntester uses continue-on-error, so it reports success
# even when the build that uploads this app failed.
echo "::error::RNTesterApp-NewArch-${{ matrix.flavor }} is missing. Check the test_ios_rntester (${{ matrix.flavor }}, frameworks: false) job."
RESULT=failed
elif [[ -f "$STATE" ]] && jq -e 'any(.flows[]; .status == "failed")' "$STATE" > /dev/null; then
RESULT=failed
else
Expand Down
Loading