[CUB3D]

Adds:

• accdata_el1
• actlrmask_el1
• actlrmask_el2
• afsr0_el2
• afsr0_el3
• ccsidr2_el1
• hacr_el2
• id_aa64isar2_el1
• id_aa64isar3_el1
• osdlr_el1
• tpidr_e3

Expands field definitions for:

• id_aa64dfr0_el1
• id_aa64dfr1_el1
• id_aa64pfr1_el1

Update (08/10/2026): Marked ready for review after #74 merged

[Copilot]

🟡 Changes recommended

Several bitfield register marker types are incorrect, preventing typed field access, alongside an incorrect ACCDATA field width.

15 open findings

• Preserve all 64 bits of ACCDATA_EL1 · New
• Use CCSIDR2_EL1 as the field register marker · New
• Use the generated register type for ID_AA64DFR1_EL1 · New
• Use the generated register type for ID_AA64ISAR2_EL1 · New
• Use the generated register type for ID_AA64ISAR3_EL1 · New
• Use OSDLR_EL1 as the Readable register type · New
• Update the PR description to match the diff · New
• Document ACTLRMASK_EL2 as an EL2 register · New
• Document HACR_EL2 as an EL2 register · New
• Use the plural noun in the field description · New
• Fix misspelled generated public value names · New
• Add the missing space in the register title · New
• Remove the unmatched trailing backtick · New
• Correct the public field description spelling · New
• Fix misspelled generated public value names · New

What changed in this PR

Adds and exports additional AArch64 system-register definitions while expanding feature-register bitfields.

Changes:

• Adds register accessors across EL1–EL3.
• Defines additional architectural feature fields and encodings.
• Exports the new registers through the public registry.

File	Description
registers/​tpidr_el3.rs	Adds TPIDR_EL3 access.
registers/​osdlr_el1.rs	Adds OS double-lock access.
registers/​id_aa64pfr1_el1.rs	Expands processor feature fields.
registers/​id_aa64isar3_el1.rs	Adds ISAR3 feature definitions.
registers/​id_aa64isar2_el1.rs	Adds ISAR2 feature definitions.
registers/​id_aa64dfr1_el1.rs	Expands debug feature definitions.
registers/​id_aa64dfr0_el1.rs	Adds DFR0 fields.
registers/​hacr_el2.rs	Adds HACR_EL2 access.
registers/​ccsidr2_el1.rs	Adds CCSIDR2_EL1 access.
registers/​afsr0_el3.rs	Adds EL3 fault-status access.
registers/​afsr0_el2.rs	Adds EL2 fault-status access.
registers/​actlrmask_el2.rs	Adds EL2 control masking.
registers/​actlrmask_el1.rs	Adds EL1 control masking.
registers/​accdata_el1.rs	Adds accelerator-data access.
registers.rs	Exports the new registers.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[berkus]

This is gonna take a while to review, if you could split it into several smaller PRs it could be easier, but if not - don't worry I'll crawl through this one eventually.

[CUB3D]

I'm in no rush and I'd rather not have to wrangle multiple different PRs. But I'll keep it in mind to keep future PRs more focused