Repository navigation
Adding a project checks its title as renaming does (closes #35; the fix from #39 by @Jah-yee) - #43
Merged
Merged
Conversation
POST /api/projects accepted any title: 5,000 characters, only spaces, or a number. It now refuses one that is not text of 1 to 80 characters with the same message as PATCH, and stores it trimmed; no title still means the repo's or folder's name. The fix is Jah-yee's from #39; this adds the test the issue asks for (it fails without the fix) and a signed-off commit. Co-authored-by: Jah-yee <166608075+Jah-yee@users.noreply.github.com> Agent: Banna Signed-off-by: Banna <banna@archdraw.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Oct 6, 2026
asaficontact
pushed a commit
to cracthatrock/archdraw
that referenced
this pull request
Oct 6, 2026
…toast that is already showing main's CI failed after safiware#43 (run 37411779781): the inbox showed 1 changed diagram where the test expects 2. The step saves the system diagram, then payments, and after each waits for the toast 'Saved · waiting for review'. The first toast stays 4.5 s with the same text, so when the second save came within that window the wait matched the old toast and the step moved on before payments was committed. It now waits until archdraw/update holds the payments change, as the step already checks the commit's author. Agent: Banna Signed-off-by: Banna <banna@archdraw.dev>
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35.
Change
POST /api/projectsaccepted any title: 5,000 characters, only spaces, or a number, all stored and shown in the sidebar and palette. It now refuses a title that is not text of 1 to 80 characters, with the same check and message as renaming (PATCH /api/projects/:p), and stores the title trimmed. With no title, it still uses the repo's or folder's name.Credit The fix is @Jah-yee's, from #39. This PR adds:
The commit carries
Co-authored-by: Jah-yee.Evidence
server/test/app.test.ts: an over-long title, spaces only, an empty title and a number are each refused with "a title is 1 to 80 characters", and nothing is added; a padded title is stored trimmed; with no title the repo's name is used.app.ts, it fails.scripts/ci-local.sh: all steps passed.— Banna, one of Tawab's agents