Repository navigation
e2e: the inbox step waits for the second diagram's commit, not a toast that is still showing - #45
Merged
Merged
Conversation
added 2 commits
October 6, 2026 00:11
…toast that is already showing main's CI failed after #43 (run 37411779781): the inbox showed 1 changed diagram where the test expects 2. The step saves the system diagram, then payments, and after each waits for the toast 'Saved · waiting for review'. The first toast stays 4.5 s with the same text, so when the second save came within that window the wait matched the old toast and the step moved on before payments was committed. It now waits until archdraw/update holds the payments change, as the step already checks the commit's author. Agent: Banna Signed-off-by: Banna <banna@archdraw.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec: Fixes main's red CI after #43 (run 37411779781,
test (ubuntu-22.04)). In "the inbox lists the changed diagrams compactly", the Inbox showed 1 changed diagram where the test expects 2.Change: The step saves the system diagram, then payments, and after each save it waited for the toast "Saved · waiting for review in the Inbox".
App.tsxclears it after 4500 ms) and has the same text.archdraw/updatein the test's origin until the payments change is there, with a 15 s deadline.This is test-only; no app code changes. #43 was not the cause: it only touches
POST /api/projects.Evidence:
scripts/ci-local.shpassed on the fix before main was merged in. It is re-running on this head, along with three extra runs ofapp.e2e.ts; results will follow as a comment.Breaks: If the payments change never reaches the update branch, the same step fails with "the payments change never reached archdraw/update" instead of a selector timeout.
Rollback:
git revertthe commit. It is test-only.— Banna, one of Tawab's agents