Skip to content

e2e: the inbox step waits for the second diagram's commit, not a toast that is still showing #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asaficontact merged 2 commits into from
Oct 6, 2026
Merged

e2e: the inbox step waits for the second diagram's commit, not a toast that is still showing #45

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de95630
e2e: the inbox step waits for the second diagram's commit, not for a …
Oct 6, 2026
383029c
Merge remote-tracking branch 'origin/main' into e2e-inbox-race
Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion app/e2e/app.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,13 @@ async function main() {
await page.keyboard.press("Control+End")
await page.keyboard.type('\nnode bank "Bank" below psp\n')
await page.keyboard.press("Control+s")
await page.waitForSelector("[data-testid=toast]:has-text('waiting for review')")
// the first save's toast ("Saved · waiting for review") is still up for 4.5 s with the same text, so the toast
// cannot tell this save apart: wait for the payments change itself on the update branch
for (let t = Date.now(); ; ) {
if (sh(origin, "show", "archdraw/update:.archdraw/payments.archdraw").includes('node bank "Bank"')) break
if (Date.now() - t > 15_000) throw new Error("the payments change never reached archdraw/update")
await page.waitForTimeout(200)
}
await page.click("[data-testid=toggle-source]")
})
await step("the inbox lists the changed diagrams compactly, Approve on top; a click opens one's colored diff; Approve publishes", async () => {
Expand Down