Repository navigation
Require an approving review before auto-merging release PRs - #343
Merged
Merged
Conversation
The ``Auto-Merge Automated PRs`` workflow merged any PR labeled ``automated-update`` as soon as CI finished green. That means the release PR auto-generated by ``auto-update-versions.yml`` could ship a bundled upstream bump (CPython point releases, OpenSSL/sqlite/expat/etc.) without any human having looked at the diff -- which is the whole reason the PR exists in the first place. Gate the ``gh pr merge`` call on at least one ``APPROVED`` review (via ``gh pr view --json reviews``). If no approvals are present, log and exit 0 so a later approval + CI re-run will merge normally. Approvals submitted on an older commit still count here; configure branch protection with ``Dismiss stale pull request approvals when new commits are pushed`` if a re-approval per push is desired.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes
Motivation
Caught during PR #338 cleanup: a CPython 3.14.9 → 3.14.10 bundled bump silently introduced a FIPS regression (#342). Had the release PR auto-merged on green CI before the FIPS job was noticed, we'd have shipped broken FIPS enforcement for 3.14 users.
Test plan