Skip to content

Require an approving review before auto-merging release PRs #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dwoz merged 1 commit into from
Nov 2, 2026
Merged

Require an approving review before auto-merging release PRs #343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion .github/workflows/auto-merge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,21 @@ jobs:
echo "No open automated-update PR matches commit ${HEAD_SHA}; nothing to merge."
exit 0
fi
echo "Merging PR #${pr_number} (head ${HEAD_SHA})."
# Require at least one approving review before merging. Without this
# gate, release PRs would merge on green CI alone -- the whole point
# of these PRs is to get human eyes on the bundled upstream bumps
# before they ship. Approvals submitted on an older commit still
# count here; configure branch protection with
# "Dismiss stale pull request approvals when new commits are pushed"
# if a re-approval per push is desired.
approved="$(
gh pr view "${pr_number}" \
--json reviews \
--jq '[.reviews[] | select(.state == "APPROVED")] | length'
)"
if [ "${approved}" -eq 0 ]; then
echo "PR #${pr_number} has no approving reviews; skipping auto-merge."
exit 0
fi
echo "Merging PR #${pr_number} (head ${HEAD_SHA}, ${approved} approval(s))."
gh pr merge "${pr_number}" --squash --delete-branch
Loading