Repository navigation
feat(website): the gateway serves a one-image site and keeps its data plane off the site's route (FD-4683) - #391
Merged
Conversation
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
williamloo-scale
changed the title
williamloo-scale
changed the title
williamloo-scale
force-pushed
the
wloo/web-app-contract
branch
from
October 30, 2026 05:23
e4c1cc6 to
f4e254f
Compare
williamloo-scale
force-pushed
the
wloo/web-apps-deploy
branch
from
October 30, 2026 05:23
ad91fbc to
a8c7be7
Compare
williamloo-scale
changed the title
… plane off the site's route (FD-4683) A website whose server image serves its pages runs as one container: /website/<name>/ and /svc/<name>/ both reach it, and it's checked at its declared health path. A site's route never forwards its data plane or env card, however the path is spelled, so an agent browsing the site can't read what grades it; agentenv reaches them through /svc/<name>/. A site built on a separate frontend image deploys as before. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
williamloo-scale
force-pushed
the
wloo/web-app-contract
branch
from
October 30, 2026 05:46
f4e254f to
2861aa3
Compare
williamloo-scale
force-pushed
the
wloo/web-apps-deploy
branch
from
October 30, 2026 05:46
a8c7be7 to
22ec1ec
Compare
# Conflicts: # AGENTS.md # src/agent_env/env/envs/multi_env.py # src/agent_env/env/envs/website.py
…the site receives is spelled (FD-4683) The guard checked the decoded path, but the proxy forwards the raw one and httpx removes its dot segments, so /website/mail/public%2Fx/../agentenv passed the guard and reached the site as /agentenv. The guard now also checks the path the site's server receives: the forwarded URL as httpx normalizes it, decoded. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…s website/v1 ready (FD-4683) The env card is the protocol layer, so a site's readiness is read from it, as computer-app/v1's ready is read of an app: once the gateway serves its card, the deploy reads each site's card through /svc/<name>/ and polls website/v1's ready until it says so, failing after 300s naming each site's problems. A site whose card has no ready, or that serves no card, is read at its stored health path instead, with a deprecation warning. The compose health check now only says the server is up: it answers its card, or for a site serving none its health path. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…D-4683) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… isn't reserved, not in a comment (FD-4683) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… and verify its state at /go (FD-4683) (#392) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
williamloo-scale
merged commit Nov 3, 2026
a8aa4a2
into
wloo/web-app-contract
20 of 21 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gateway runs a website whose server image serves its pages as one container:
/website/<name>/and/svc/<name>/both reach it, and compose checks it at its declared health path. A site's route now never forwards its data plane or env card (/agentenv/…,/.well-known/agent-env.json, however the path is spelled, including an encoded slash beside a dot segment, which the guard reads as the site's server will receive it), so an agent browsing a site can't read what grades it; agentenv still reaches them through/svc/<name>/, as the design'swebsite/v1contract requires. Sites built on a separate frontend image deploy as before.Validation: unit suite passes, with tests for the one-image compose and topology, and the reserved paths through the site route versus
/svc/, with encoded-slash and dot-segment spellings.🤖 Generated with Claude Code
The PR appears safe to merge; no new actionable defects remain.Summary
The gateway now serves one-image websites and blocks their data routes and env cards through
/website/<name>/, while keeping/svc/<name>/available to framework calls.Diagram
%%{init: {'theme': 'neutral'}}%% flowchart LR Browser --> SiteRoute["/website/name/"] SiteRoute --> Guard{"Reserved path?"} Guard -->|Yes| Refused["404"] Guard -->|No| Pages["Frontend image, or server image"] Framework --> ServiceRoute["/svc/name/"] ServiceRoute --> Server["Server image"] Verifier["website_state_verifier"] --> ServiceRouteReviews (13) · Last reviewed commit: "feat(website): build a site's server ima..." · Reviewed by Greptile