Skip to content

fix(validate): count inherited geometry in palette token usage - #41

Merged
scbrown merged 2 commits into
mainfrom
grant/palette-source-usage
Nov 15, 2026
Merged

scbrown merged 2 commits into
mainfrom
grant/palette-source-usage

Conversation

@scbrown

@scbrown scbrown commented Nov 12, 2026

Copy link
Copy Markdown
Owner

A sprite that uses a named swap palette can inherit all its geometry through source, yet validation counts only its directly declared region keys and reports used tokens as unused. Resolve effective geometry at end-of-file through the existing sprite registry before checking named palette usage. This follows source chains and forward references and respects extends patches/removals; genuinely unused tokens still warn.

Closes #39.

Validation: four regression cases fail on the base, then pass; a fifth verifies the original swap fixture succeeds under strict CLI validation. Full cargo test: 2,652 pass, 37 ignored, zero failures across 25 suites. Clippy all targets with lsp,wasm and warnings denied passes. HOME guard: 162 paths and 5 UID resources untouched.

Demo: the same palette swap under strict validation goes from false unused-a warning/exit1 to no issues/exit0. Caption and reproduction, terminal recording, timing. Source-checkout demonstration; no installed executable changed.

Bead: aegis-sg3

Overlap preflight: c03039a00ca57330d5e82d97531170615081c213c7dacd34b538abaab13945c7

@scbrown scbrown changed the title Count inherited geometry in palette token validation fix(validate): count inherited geometry in palette token usage Nov 15, 2026
@scbrown
scbrown merged commit b03acef into main Nov 15, 2026
16 checks passed
@github-actions github-actions Bot mentioned this pull request Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

validate: false 'Palette tokens never used' for a palette used only through source:

1 participant