Repository navigation
fix(validate): count inherited geometry in palette token usage - #41
Merged
Merged
Conversation
This was referenced Nov 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A sprite that uses a named swap palette can inherit all its geometry through
source, yet validation counts only its directly declared region keys and reports used tokens as unused. Resolve effective geometry at end-of-file through the existing sprite registry before checking named palette usage. This follows source chains and forward references and respects extends patches/removals; genuinely unused tokens still warn.Closes #39.
Validation: four regression cases fail on the base, then pass; a fifth verifies the original swap fixture succeeds under strict CLI validation. Full
cargo test: 2,652 pass, 37 ignored, zero failures across 25 suites. Clippy all targets with lsp,wasm and warnings denied passes. HOME guard: 162 paths and 5 UID resources untouched.Demo: the same palette swap under strict validation goes from false unused-a warning/exit1 to no issues/exit0. Caption and reproduction, terminal recording, timing. Source-checkout demonstration; no installed executable changed.
Bead: aegis-sg3
Overlap preflight: c03039a00ca57330d5e82d97531170615081c213c7dacd34b538abaab13945c7