Skip to content

chore(deps-dev): bump nock to 15.0.5 and update web-api tests - #2805

Closed
mwbrooks wants to merge 1 commit into
mainfrom
mwbrooks-nock-15
Closed

mwbrooks wants to merge 1 commit into
mainfrom
mwbrooks-nock-15

Conversation

@mwbrooks

Copy link
Copy Markdown
Member

Summary

This pull request moves the web-api and webhook packages to nock 15.0.5 for maintainers, so the recurring dependabot bumps stop failing CI. It replaces #2802, #2799, and #2800.

  • nock 15 reads a two-argument reply callback as the old callback style and waits for a callback that never runs, which is what stalled the web-api tests. Reply callbacks now take no arguments, or the new Request argument when they check the request body.
  • nock 15's delay() only delays the response body. The concurrency tests now hold the response headers with an async reply, because headers arriving is what frees a slot in the client's request queue.
  • Test and dev dependency changes only, so there is no changeset.

Testing

Requirements

nock 15 reads a two-argument reply callback as the callback style, so
those tests hung. Reply callbacks now take the Request argument, and the
concurrency tests hold the response headers with an async reply because
delay() only delays the response body now.
@mwbrooks mwbrooks added tests M-T: Testing work only pkg:web-api applies to `@slack/web-api` pkg:webhook applies to `@slack/webhook` dependencies Pull requests that update a dependency file labels Oct 29, 2026
@mwbrooks mwbrooks self-assigned this Oct 29, 2026
@changeset-bot

changeset-bot Bot commented Oct 29, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 5301749

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Oct 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.22%. Comparing base (6f6fbd1) to head (5301749).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2805      +/-   ##
==========================================
- Coverage   89.25%   89.22%   -0.03%     
==========================================
  Files          65       65              
  Lines       10562    10562              
  Branches      489      489              
==========================================
- Hits         9427     9424       -3     
- Misses       1103     1105       +2     
- Partials       32       33       +1     
Flag Coverage Δ
cli-hooks 89.21% <ø> (ø)
cli-test 89.21% <ø> (ø)
logger 89.21% <ø> (ø)
oauth 89.21% <ø> (ø)
socket-mode 89.21% <ø> (ø)
web-api 89.21% <ø> (ø)
webhook 89.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwbrooks

Copy link
Copy Markdown
Member Author

note: Closing for now, because nock 15 requires Node.js 22.20 or later and we still support Node.js 20. #2806 holds nock at 14.x and links back here, so these test changes are easy to pick up once Node.js 20 support is dropped.

@mwbrooks mwbrooks closed this Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file pkg:web-api applies to `@slack/web-api` pkg:webhook applies to `@slack/webhook` tests M-T: Testing work only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant