Skip to content

ci(dependabot): hold nock at 14.x while Node.js 20 is supported - #2806

Merged
mwbrooks merged 1 commit into
mainfrom
mwbrooks-hold-nock-14
Oct 30, 2026
Merged

mwbrooks merged 1 commit into
mainfrom
mwbrooks-hold-nock-14

Conversation

@mwbrooks

Copy link
Copy Markdown
Member

Summary

This pull request stops dependabot from opening nock 15 bumps for maintainers while we still support Node.js 20. nock 15 requires Node.js 22.20 or later, so every bump fails the Node.js 20 test jobs (#2782, #2795, #2802).

Testing

Requirements

nock 15 requires Node.js 22.20 or later, so its bumps fail the Node.js
20 test jobs. #2805 has the test changes nock 15 needs for when Node.js
20 support is dropped.
@mwbrooks mwbrooks added this to the web-api@next milestone Oct 29, 2026
@mwbrooks mwbrooks added pkg:web-api applies to `@slack/web-api` pkg:webhook applies to `@slack/webhook` dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Oct 29, 2026
@mwbrooks mwbrooks self-assigned this Oct 29, 2026
@changeset-bot

changeset-bot Bot commented Oct 29, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8aa1fc4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.25%. Comparing base (9c6893e) to head (8aa1fc4).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2806      +/-   ##
==========================================
- Coverage   89.27%   89.25%   -0.02%     
==========================================
  Files          65       65              
  Lines       10562    10562              
  Branches      489      489              
==========================================
- Hits         9429     9427       -2     
- Misses       1100     1102       +2     
  Partials       33       33              
Flag Coverage Δ
cli-hooks 89.21% <ø> (ø)
cli-test 89.21% <ø> (ø)
logger 89.21% <ø> (ø)
oauth 89.21% <ø> (ø)
socket-mode 89.21% <ø> (ø)
web-api 89.21% <ø> (ø)
webhook 89.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎁 @mwbrooks LGTM! Holding nock at 14.x on all three entries that open these bumps is the right call while Node.js 20 is still supported, and the comments make it easy to pick back up later.

@zimeg zimeg modified the milestones: web-api@8.3.0, web-api@next Oct 30, 2026
@mwbrooks

Copy link
Copy Markdown
Member Author

Thanks @zimeg for the quick review and for checking all three entries! 🙇

@mwbrooks
mwbrooks merged commit 31fcaa3 into main Oct 30, 2026
21 of 22 checks passed
@mwbrooks
mwbrooks deleted the mwbrooks-hold-nock-14 branch October 30, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code pkg:web-api applies to `@slack/web-api` pkg:webhook applies to `@slack/webhook` semver:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants