Repository navigation
Skip the data submodule when copying Desk files for desktop builds - #359
Merged
Merged
Conversation
Contributor
|
Merge verdict: SAFE TO MERGE (PR guard passed on dcf1356). Use "Squash and merge". PR guard output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope: .github/scripts/build_desk.py
The squirrelgo-v0.1.4 desktop builds (Linux, Windows, macOS) failed with
IsADirectoryError: .../data(run).git ls-fileslists thedata/submodule as a single entry, and the build script tried to copy it as a file.The script now reads
git ls-files -sand skips submodule entries (mode 160000). The Desk's web apps load their own generated files, so nothing they need comes from the submodule. Every other tracked file is still copied, as before.After merge, rerun Desk desktop builds by hand with tag
squirrelgo-v0.1.4. The workflow takes the build script from main, so the fix applies to the existing tag.Checks:
python3 .github/scripts/pr_guard.py --base origin/main --head HEAD