fix(pixii): track the SunSpec sources for status decoding - #148
Conversation
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 426ff55dbf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,5 +1,5 @@ | |||
| name: "pixii" | |||
| version: "2.1.5" | |||
| version: "2.1.6" | |||
There was a problem hiding this comment.
The only intended change is adding upstream_docs, which spec/manifest-v2.md explicitly defines as descriptive metadata that is not copied into index.yaml and never affects installation or runtime; the existing changelog likewise states that such changes require no driver-version bump. Raising this to 2.1.6 changes the Lua source hash and advertises a new signed runtime artifact, causing consumers to treat unchanged driver behavior as an update and requiring unnecessary bundled-version synchronization. Leave the driver and manifest at 2.1.5 and omit the generated catalog/support version changes.
Useful? React with 👍 / 👎.
1 participant
Record the SunSpec Device Information Model specification and model 802 register definition in Pixii's
upstream_docs, so the weekly watcher can detect changes. Addresses the review finding on #147.Bump Pixii to 2.1.6 because the manifest is part of the versioned driver artifact. Lua behavior is unchanged from 2.1.5; only its version changes. Regenerate the source hash and catalog. This completes the owner's requested Pixii beta release without touching the separate HeishaMon entries in #60/#66 or the baseline owned by #146.
Validation:
make test-driver ID=pixii(103 passed, 13 skipped) andmake check(4742 passed, 913 skipped). Both official source URLs resolve. No hardware claim or control change.