fix(control): use the same battery power limits in planning and dispatch - #1468
Merged
Merged
Conversation
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and result
A 20 kWh battery with no configured power limits received a 10 kW planner limit (0.5C) while dispatch silently capped commands at 5 kW. The planner could schedule energy that Core would never command, even with the external ramp disabled.
Planning and dispatch now share one resolver. Missing limits use the existing 5 kW dispatch default; energy capacity does not establish a power rating. Driver limits and battery overrides retain their precedence. One-sided explicit zero still blocks that direction, and both-zero overrides retain the existing invalid-config fallback policy. Boot and config reload use the same resolver.
Scope and safety
main.go; these changes are confined to the two battery-limit builders, with no shared hunks. No existing PR branch was changed.Verification
make verifypasses: Go suites, migration/container/release checks, native solver checks, vet and build.Checklist