Repository navigation
fix(server): Server.__init__ compatibility with mcp>=1.12.0 - #326
Closed
Daniyal0100101 wants to merge 1 commit into
Closed
Daniyal0100101 wants to merge 1 commit into
Daniyal0100101 wants to merge 1 commit into
Conversation
|
Hi @Daniyal0100101 - since this PR has been open a while, I rebased your patch onto current main and verified it (69/69 unit tests pass against mcp 1.29.1): see #331. Your original diff was applied as-is with attribution in the commit message. Noted there: with mcp 2.x now released, the cap in this patch is the critical part - uncapped installs currently break at import time. |
Author
|
Superseded by #331, which carries this patch forward on current main and verifies it against the current MCP 1.x release. Closing this one to avoid keeping duplicate PRs open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fix
Server.__init__compatibility withmcp>=1.12.0(issue #322).Root Cause
In
mcp>=1.12.0, theServer.__init__signature changed:The old code
Server(self.name, self.description)passedself.descriptionas the second positional argument, which now maps toversioninstead ofinstructions. This caused:Fix
fastapi_mcp/server.py(line 144): ChangedServer(self.name, self.description)toServer(name=self.name, instructions=self.description)— uses keyword arguments so the mapping is explicit and version-agnostic.pyproject.toml: Pinnedmcpdependency to>=1.12.0,<2.0.0to prevent future breaking changes frommcp 2.x.Testing
FastApiMCPinstantiation,mount_http(),mount_sse()all work withoutTypeErrorRelated
Closes #322