Repository navigation
chore(sync): merge upstream nightly v0.1.11-nightly.20261117.4851, adopting upstream Issues - #469
Merged
Merged
Conversation
…heir project (pingdotgg#37682) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…hread (pingdotgg#37725) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… with web (pingdotgg#37743) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…er area (pingdotgg#37508) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…lds (pingdotgg#37755) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…tes instead of running forever (pingdotgg#37728)
…s an error (pingdotgg#37747) Co-authored-by: Martin Bergo <14320143+mInrOz@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ingdotgg#37745) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ingdotgg#37764) Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…read span (pingdotgg#37763) Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…tead of re-reading every minute (pingdotgg#31969)
…away (pingdotgg#35761) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…otgg#28635) Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…longer drop a short thread (pingdotgg#37797)
…n recovery (pingdotgg#38241) Co-authored-by: Grok 4.7 <noreply@x.ai> Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ngdotgg#38262) Co-authored-by: Cursor <cursoragent@cursor.com>
…g#38313) Co-authored-by: Julius Marminge <julius0216@outlook.com>
Upstream's Issues feature takes the issue tab, thread-details rows, issue tools and /issues. The fork roadmap moves to /roadmap, the work section mounts in upstream's issue detail panel, link_issue/unlink_issue are deleted, and create_issue/set_issue_state are hidden from repository-managed threads. Closes #454. Part of #451. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…m code The desktop app still shows the connecting splash, the issue-work lock reads findThread, the delegated-task progress read uses getThreadShell, and pending background tasks keep the fork's startedAt; the tests now provide or expect each of these. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It fails once any extra migration is registered, on main as on this sync, so the interrupt point it pins moves with setup work; #468 tracks whether that is a real permit race or test fragility. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 18, 2026
… below managed threads Upstream's link_issue/unlink_issue emit thread.issue-synced, which the roadmap refresh ignored, so the roadmap and thread-details Issues stayed stale. The managed-thread mark now also covers every descendant of a managed thread (owner decision, 2026-11-17) through one bounded parent walk, and its reads use the read-only connection instead of the writer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tannerpolley
marked this pull request as ready for review
November 18, 2026 01:05
This was referenced Nov 18, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #454. Step 3 of 7 for #451.
What this does
This is a real merge of upstream nightly
v0.1.11-nightly.20261117.4851, the newest nightly when the work started. Upstream's Issues feature becomes the base, as the #451 plan and owner decisions require.mainwas then merged in twice, with no rebase. The second merge brought in the #449 fix (#466) and #464; a third brought in the latest web fixes.issueright-panel tab, the thread-details issue rows,/issues, and its issue tools (list_issues,read_issue,create_issue,comment_on_issue,set_issue_state,link_issue,unlink_issue,list_thread_issues)./roadmap. The command palette gains "Open roadmap", and "Start agent on issue…" with no thread goes there. The roadmap opens issues in upstream's detail panel. The per-repository issues side panel (the forkissuessurface) still shows the roadmap, and its rows open upstream'sissuetab beside the thread.IssueDetailPanelthrough one hook line (<IssueWorkSlot …/>). The slot is gated on theissueWorkcapability and GitHub issues. The fork's own issue detail panel andThreadIssueSurfaceare deleted. The ⋯ menu keeps only Unlink (old table link), Refresh and Copy issue number.link_issue/unlink_issueMCP tools are deleted (IssueMcpTools.ts), and upstream's toolkit is registered.create_issueandset_issue_stateare hidden from repository-managed threads and every thread below them (owner decision, 2026-11-17).IssueChangeService.isManagedCallerwalks stored parent links in one depth-bounded recursive read on the read-only connection. Hiding usesMcpSchema.EnabledWhen, which is enforced on both tools/list and tools/call, sopropose_issue_changestays their gated path. Every other issue tool stays available.McpHttpServer.test.tslists the realIssuesToolkitfor a managed thread, its child and an ordinary thread.IssueChangeService.test.tschecks the lineage query on a child, a grandchild, a claiming worker, the worker's child, and an unrelated thread and its child.thread.issue-synced, which upstream'slink_issue/unlink_issueemit. The test is inIssueRoadmap.test.ts.linkedIssueis kept beside upstream'sthread.issues[].IssueLinks.enrichnow also readsthread.issues[]GitHub links, which count as live work but cannot be unlinked from there. The new case is inIssueLinks.test.ts.issuetabs, keyed by repository, close on load. The test is inrightPanelStore.fork.test.ts.Conflict resolutions
_chat.issues.tsx, ChatMarkdown issue links, RightPanelTabs issue cases, rightPanelStore issue surface, PullRequestSummaryTab meta rows, presentation issues atom, thread-details issue rows)issueTabs.ts(fork ref ↔ upstreamIssueSurfaceTarget) and the/roadmaproute.ws.tsissues.*andissueTrackers.*handlers added; both prefixes split out.ServerEnvironment/ contractsenvironment.tsissuescapability plus the fork issue capabilities.GitVcsDriverCore.createWorktreeserverSettings.tsServerBrowser.tsawaitShownwait, then the fork's hide on an existing tab.ThreadLaunchService.tsexisting_worktreecase.orchestrationV2.tscontractspendingBackgroundTaskSchemaplus upstream'srunId.ProjectionStore.ts,Orchestrator.control-reads.test.ts,Observability.ts,server.tsProjectionStore.ts: the interface block keeps both sides' methods, andlistActiveShellIndexis identical to upstream's (it matches migration 98).Orchestrator.control-reads.test.ts: the fork test, with upstream's failed-span tracer check ported into the fork's parent-PR delegate test.Observability.tsandserver.ts: both sides' additions.Orchestrator.ts,EffectOutbox,EffectWorkerand the migrations merged without conflicts.IssueWorkDispatchnow uses upstream'sfindThread(an expected miss is not an error span), which removed two new control-reads failures. The #466 fixes are intact: run-scoped delegated reads,Layer.fresh(layerTest), andINDEXED BYon the usage-limit index.packages/source-control-forgejoDesktopApp.test.tsshowConnectingSplashmock (the fork app still calls it).agentContextBudget.jsonBehavior ledger (
scripts/fork-sync/lost-fork-code.py 4a0f11ee58 v0.1.11-nightly.20261117.4851 e467a6504f)The script flags 47 hunks in 152 files changed on both sides, plus 3 deleted fork files. None is a silent loss.
GitVcsDriverCore.ts(3 hunks),serverSettings.tsChatMarkdown.tsx(2),ChatView.tsx(2),RightPanelTabs.tsx(7),PullRequestSummaryTab.tsx(2),rightPanelStore.ts(6),presentation.tsissuesurface and rows). Fork-only pieces re-added: theissueslist surface, the issue-host link preview,issueSurfaceexport, and v18 migration.NO_MODIFIER_CLICKis gone with upstream'sonOpenFallback.routes/_chat.issues.tsx,CommandPalette.tsx(2)/roadmap; upstream keeps/issues.t3McpToolPresentation.tslink_issue/unlink_issuepresentation entries went with the tools; upstream's entries stay.IssueMcpTools.ts,issues/IssueDetailPanel.tsx,ThreadIssueSurface.tsx(deleted)IssueWorkSlot; upstreamissuesurface.docs/user/source-control.md(2)packages/source-control-forgejo(14)DesktopApp.test.tsagentContextBudget.jsonReverse audit (upstream code the merge did not keep): only the deliberate items above. Upstream's
savedViews.tsandgraphql.config.tscame along unchanged.Gates
~/.t3/userdata. Upstream's97_IssueTrackerBindingsand98_ActiveShellIndexIndexesapplied. The fork ledgert3_fork_migrationsstayed at 30/30, andissue_thread_linkswas preserved.PRAGMA integrity_checkreturned ok..github/actions), so there was nothing togh workflow disable.mcpToolListJsonByteswent from 79439 to 80901 (+1462: upstream's 8 issue tools in, the fork's 2 link tools out).claudeSystemAppendBytes(6729) andcodexAdditionalContextBytes(8122) are unchanged. Needs theagent-context-increaselabel. I did not cut any text, so no paid evals were run.main(with fix(server): restore the reads and test isolation the 20261116 sync merge dropped #466):Orchestrator.control-reads,FoundationPersistenceandProjectionStore.fork, plusAgentContextBudget, give 4/4 files and 119/119 tests passing.vp run check:changed(withCHECK_CHANGED_TIMEOUT=3600, because the 405 selected test files ran past the default 900 s underagent-heavy):ComposerCommandPopover.tsx,projectIcon.ts,asset-url-state.ts), in files this branch does not change.main, and ran the onesmaindoesn't have on the upstream tag:GitVcsDriverCorefailures pass withGIT_CONFIG_GLOBAL=/dev/null; the machine's global git hooks cause them.DesktopApp(2, the splash mock),OrchestratorMcpService(agetThreadShellmock for a new upstream test),ThreadManagementService(afindThreadmock) and aClaudeAdapterV2roster expectation (the fork'sstartedAt).mainonce one empty migration is registered; the sync adds upstream's 97 and 98.Manager.testreal-PTY shell resolution case.ChatMarkdowndouble-click.main(16): these files are not in 11 server tests fail on main: FoundationPersistence (9) and Orchestrator.control-reads (2) #449's list only becausemain's owncheck:changednever selects them:ClaudeAdapterV2monitor typing (fork and upstream copies) and roster (fork copy);CodexAdapterV2.forknative subagents (2);ProviderTurnStartService.fork(4);runtimeLayer(2);ServerBrowserdesktop-tab unload;ScheduledTaskServicerefused-dispatch message;Manager.forkinline shell.GIT_CONFIG_GLOBAL=/dev/null, 406 files): 19 of 9159 failed. These are exactly main's 16 listed above, the two 11 server tests fail on main: FoundationPersistence (9) and Orchestrator.control-reads (2) #449 web failures (ChatMarkdowndouble-click andopenRepositoryIssueLink), and upstream'sManager.testreal-PTY case. There are no new failures; typecheck shows only the 3 mobile errors, and every other step passes.openRepositoryIssueLink(1),ChatMarkdowndouble-click (1) and mobile typecheck (3) remain; upstream fixes none of them.vp run dev --no-seed, with one synthetic project and no seeded data. Upstream/issueslists and opens issues; the work section (Start agent, Prepare draft, Ask agent, ⋯, live state) renders in upstream's detail panel./roadmaprenders the roadmap, and its URL target opens upstream's detail panel with the work section. The thread's per-repository Issues side panel shows the roadmap, and a row opens upstream's#451tab beside the thread. The dev server was stopped.Surfaces
Model: Claude Opus 5.5 in Claude Code, running in T3 Code.
🤖 Generated with Claude Code