Repository navigation
fix: preserve committed writes after JDBC connection cleanup faults - #234
Draft
philipgreat wants to merge 1 commit into
Draft
philipgreat wants to merge 1 commit into
philipgreat wants to merge 1 commit into
Conversation
philipgreat
marked this pull request as draft
October 19, 2026 17:27
This was referenced Oct 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #233. This is a stacked P1 review PR on the integrated Committed Mutation candidate, not a request to bypass #216/#225 review gates.
After JDBC commit succeeds, autoCommit restoration or close can fail. Previously the executor reported an ordinary transaction failure although the SQLite row and Outbox had already committed, inviting a duplicate retry. This change preserves the committed outcome and emits a sanitized operational warning. It also prevents a user-installed JUL handler from changing the committed result.
Verified with real SQLite fault injection: restoration failure, close failure, and throwing warning handler. Focused tests: 3/3 new and 36/36 GraphTrace. The affected Maven reactor test suite exited 0. The committed-events example passed two native delivery/recovery rounds and two generated SQLite to DuckDB Q readback rounds, with generated library hash unchanged.
Scope: a SQLException thrown by commit itself is an ambiguous-outcome problem and is not reclassified as success here. Human review and the separate audit-delivery API choice remain required before any main merge.