Conversation
GitHub Actions Integration
✅ All 1 passed. |
Without `install_args`, `mise install` resolves every tool in the calling repository's mise config. `packer-templates` pins `packer` and `terraform` in `.tool-versions`, neither of which a lint job runs, as the Terraform integration workflows already avoid by naming the tools they need.
Member
Author
|
Added the missing Without it, |
…se config Drop the `python_version` input and the throwaway global mise config it was written to, matching the Terraform integration workflows since #18: the tools and their versions come from the calling repository's own `mise.toml` or `.tool-versions`, with no workflow-side default. A caller therefore has to pin `python` there. Pass the project directory as `working_directory` as well, so a `mise.toml` placed there overrides the repository-wide one.
Member
Author
|
Same treatment as the Packer workflow — 5afd15c.
Companion change on the consumer side: tedilabs/packer-templates#17 folds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Background
The Ansible half of #1, split out so it can be reviewed and adopted on its own. #1 keeps the Packer actions and the
packer.templates.integrationworkflow; nothing is shared between the two halves, so the split is a clean cut with no changes to the content.CI building blocks for the Ansible project in the
packer-templatesrepository, following the same convention as theterraform.*actions and integration workflows: the logic lives in a composite action and the workflow only wires it together.🔗 Related Issues
⚙️ Description
New composite action
ansible.ansible-lintansible-lintfrom the project directory, optionally installing Galaxy collections firstIt takes
target_dirand follows the check-action interface every check action onmainnow has: it resolves the target, runs throughshell.run, exposesskipped,stdout,stderr, andexitcode, and on failure appends its output to the job summary throughgithub.step-summary.requirements_fileinstalls the Galaxy collections intoRUNNER_TEMPrather than the checkout, so they resolve for linting but are never linted themselves.ANSIBLE_COLLECTIONS_PATHis pinned during the install, otherwiseansible-galaxyreports the collections as already present when a copy exists elsewhere on the runner and installs nothing.annotations_enabled(defaulttrue) re-runsansible-lintwith-f jsonon failure and turns each finding into a workflow error, warning, or notice, matching the interface feat(actions): annotate the failing lines from validate, tflint, and actionlint #24 and feat(actions): annotate findings from terraform fmt, terraform-docs, and check-jsonschema #26 gave the Terraform and GitHub Actions checks.target_dirholds no YAML files, sinceansible-lintexits 0 there and would report a vacuous pass.--nocoloris passed so the job summary does not carry escape sequences.New reusable workflow
ansible.integration.yamllintansible-lintand lint one Ansible project directorypythoncomes frommise.setup-tools, so a repository's ownmise.tomlor.tool-versionsstill wins over the workflow'spython_versiondefault.ansible-lintis then installed withpip, pinned byansible_lint_versionwhen it is set.Validation
yamllint(repo config) andactionlintpass on both files.The action's script was previously executed directly against a checkout of
tedilabs/packer-templates:ansible/requirements.yamlinto an empty pathansible-lintagainstansible/productionprofile, no escape sequences in the log🚨 To Reviewers
The two files are byte-identical to their state on
feat/packer-workflowsat the head of #1, so a review that already covered them there carries over.