Repository navigation
Map Android barcode bounds into the visible scan frame - #812
Open
zack-dev-cm wants to merge 1 commit into
Open
zack-dev-cm wants to merge 1 commit into
zack-dev-cm wants to merge 1 commit into
Conversation
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #484. Android scan-frame selection assumes a 90° image rotation and scales the axes independently. With a 1280×720 zero-rotation fixture, the original compiled
CKCameracallback emitsOUTSIDEand rejectsINSIDE.Carry an immutable image-geometry snapshot from the analyzer and map ML Kit's rotation-adjusted boxes through sensor coordinates into the actual preview/scan-frame coordinates. Account for view offsets and matrices, use full
RectFcontainment, and discard selections when the preview transform is unavailable or stale. CameraX 1.4.2 supplies the sensor matrices; ImageCapture construction and binding are unchanged.Preserve public constructors, the raw-size callback, format filtering, no-frame behavior, event shape and throttling. Scanner ownership is addressed in #813, executor reattachment in #817, and CI toolchain drift in #816.
How did you test this change?
Independent head
d218635, based ona2a81ce:INSIDE. Sensor/preview metadata is synthetic.INSIDEthrough its JavaScript callback on an Android 35 emulator with image-file camera input. The installed iOS example completes three mount/return cycles on an iOS 26.2 simulator.The four-PR merge guide identifies the overlapping files and the exact resolution at
7ffe27b. Its public validation passes 41 Robolectric tests with zero skips, TypeScript, ESLint and installed Debug AAR builds in both architectures; per-suite summaries and artifacts are available.Upstream workflows await approval. Device-specific reproduction of #484 and physical-camera validation are not established. The simulator checks exercise navigation. The baseline default-Xcode build failure is addressed separately in #816.