Skip to content

Add labels to plugin_repo build defs #3650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SpangleLabs merged 2 commits into from
Nov 4, 2026
Merged

Add labels to plugin_repo build defs #3650

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f04c1dd
Add labels to plugin_repo build defs
Nov 3, 2026
1367511
Switch the labels from the subrepo, to the remote file
Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion rules/subrepo_rules.build_defs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ def local_repository(name:str, path:str):
path = path,
)

def plugin_repo(name:str, revision:str, plugin:str="", owner:str="please-build", hashes:list=[]):
def plugin_repo(name:str, revision:str, plugin:str="", owner:str="please-build", hashes:list=[], labels:list=[]):
"""Defines a please plugin to use from the configured plugin repositories. See
https://please.build/config.html#please.pluginrepositories for more information.

Expand All @@ -328,6 +328,7 @@ def plugin_repo(name:str, revision:str, plugin:str="", owner:str="please-build"
plugin (str): The name of the plugin. Defaults to the name of this rule.
owner (str): The owner of the plugin to be passed to the template URLS.
hashes (list): A list of valid hashes for the downloaded archive file.
labels (list): Any labels which are applied to the build target.
"""
plugin = plugin or name
urls = [url.format(owner=owner, revision=revision, plugin=plugin) for url in CONFIG.PLUGIN_REPOS]
Expand All @@ -338,6 +339,7 @@ def plugin_repo(name:str, revision:str, plugin:str="", owner:str="please-build"
url = urls,
out = name + '_' + basename(urls[0]),
hashes = hashes,
labels = labels,
)
extract_rule = build_rule(
name = name,
Expand Down
Loading