Repository navigation
Add labels to plugin_repo build defs - #3650
Merged
SpangleLabs merged 2 commits intoNov 4, 2026
Merged
SpangleLabs merged 2 commits into
SpangleLabs merged 2 commits into
Conversation
peterebden
approved these changes
Nov 4, 2026
peterebden
requested changes
Nov 4, 2026
peterebden
left a comment
peterebden
left a comment
Collaborator
There was a problem hiding this comment.
okay I see given the test failure - subrepo isn't a build target itself so it doesn't have labels. You probably want them on one of the others, maybe the remote_file?
Contributor
Author
Yeah, I did debate which target to add it on, I suppose it doesn't matter much which one it is for my purposes. |
peterebden
approved these changes
Nov 4, 2026
SpangleLabs
added a commit
that referenced
this pull request
Nov 5, 2026
The extract_rule overrides the remote_rule, which means the labels for the remote_rule will never be seen. We need instead to set the labels on the extract_rule, so we actually get the resulting labels. We can't put them on the subrepo rule because it's not a real rule in the same way. But that also means we don't have to worry about the subrepo overriding it from the extract rule This is a fix for my last PR, #3650 , basically Co-authored-by: roselyn <roselyn@thoughtmachine.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We would like to track these a bit better via labels (specifically for dependency metadata), but first we need these to be able to take labels. So, let's add a labels parameter to plugin_repo