Skip to content

fix: improve log browsing and agent events - #442

Merged
Ziinc merged 3 commits into
mainfrom
ziinc/implement-log-viewer-updates-and-fixes
Sep 13, 2026
Merged

Ziinc merged 3 commits into
mainfrom
ziinc/implement-log-viewer-updates-and-fixes

Conversation

@Ziinc

@Ziinc Ziinc commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Motivation

  • Improve log exploration UX: enable text selection, VSCode-like find, single-line truncated rows with inspect/send flows, and fix agent output being appended to a single row.
  • Move checks/agent switcher into the nav and tidy filter/factory labels and layout.

Description

  • New LogFeed: single-line truncated rows, drag/multi selection, inspect panel, and send-to-agent shown only when one row is selected.
  • Added VSCode-style Cmd/Ctrl+F search overlay with highlighting, next/previous navigation, and auto-scrolling matches.
  • Selection-based floating toolbar to send highlighted text to an agent; contextual send in the inspect panel.
  • Replaced Checks/Agent buttons with a nav select, removed storage-path labels, and constrained search width.
  • Backend change in agent_chat to persist incremental terminal updates as separate timestamped agent events instead of replacing the last event.
  • Added LogFeed unit tests and updated integration tests to reflect the UI changes.

Testing

  • npm run check succeeded and lint/format checks passed.
  • Unit tests: src/components/LogFeed.test.tsx and src/lib/agentChatLogs.test.ts passed.
  • Rust tests/integration requiring system libs or the NAPI addon failed to build in this environment due to missing glib-2.0 / src-tauri/target artifacts.
    [Codex Task](

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

CI lint (no-unexpected-multiline) failed on the newline between
querySelectorAll(...) and [next] in moveMatch; split into an
intermediate variable instead.

Ziinc commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator Author

Merged latest origin/main into this branch (clean merge, one file — src-tauri/src/core/agent_chat.rs — auto-resolved by git, no manual conflict markers) and fixed the CI failure that was reported for de19620.

CI failure diagnosis (run 34305409625, 2 failed jobs):

  1. verify / verify / ubuntu-22.04 (lint) — fixed, pushed in 92a63b8a:

    • src/components/LogFeed.tsx:115 — ESLint no-unexpected-multiline: a newline between .querySelectorAll(...) and [next] in moveMatch was being parsed as ambiguous property access. Split into an intermediate matchEls variable. This was introduced by this PR's own diff.
    • The other lint failure reported in that run (test/integration/workspace/create-pr.test.tsx exceeding the 500-line max-lines limit) is now moot — the merge with origin/main brought the file back down to 432 lines.
  2. rust / test / windows-latestnot fixed here, pre-existing on main: 5 Windows-only test failures (jj::tests::reconcile_detached_external_checkout_reparents_home, reconcile_external_checkout_preserves_real_local_edit, reconcile_external_checkout_reparents_home_without_false_changes, reconcile_reparents_when_git_head_was_already_imported, commands::pty_commands::tests::resolves_workspace_id_to_absolute_working_directory). These come from main's home-repo reconcile logic (f41639b6) and are unrelated to this PR's log-viewer changes, so I left them alone rather than push an unrelated fix.

Also found (pre-existing on main, not touched):

  • npm run lint: src/components/RemoteRepoScreen.tsx (unused exported function) and test/integration/sidebar-branch-switch-click-lock.test.tsx (userEvent.setup() placement) both already fail lint on main.
  • npm run check:format: CommandPalette.tsx, WorkspaceDeletion.tsx, WorkspacePicker.tsx already fail biome format on main (a <p> wrapping difference) — LogFeed.tsx also needed a biome format pass after my fix, which is included in the pushed commit.

Branch is up to date with main and pushed to origin/ziinc/implement-log-viewer-updates-and-fixes.


Generated by Claude Code

@Ziinc
Ziinc merged commit 6d0fd53 into main Sep 13, 2026
7 checks passed
@Ziinc
Ziinc deleted the ziinc/implement-log-viewer-updates-and-fixes branch September 13, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants