Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 31 additions & 11 deletions src-tauri/src/core/agent_chat.rs
Original file line number Diff line number Diff line change
Expand Up @@ -342,26 +342,45 @@ fn update_last_agent_message(chat: &mut AgentChat, screen: &str, timestamp: &str
.last()
.map(|m| m.role == ChatRole::User)
.unwrap_or(true);
if chat
let previous_agent = chat
.messages
.iter()
.rev()
.find(|m| m.role == ChatRole::Agent)
.is_some_and(|m| m.message == agent_message)
{
.take_while(|m| m.role == ChatRole::Agent)
.map(|m| m.message.as_str())
.collect::<Vec<_>>()
.into_iter()
.rev()
.collect::<String>();
if previous_agent == agent_message || agent_message.is_empty() {
return;
}
// Terminal snapshots are cumulative. Persist only the newly arrived portion
// so every screen update remains an individually timestamped log event.
let event_message = if !last_is_user {
agent_message
.strip_prefix(&previous_agent)
.map(trim_whitespace)
.filter(|message| !message.is_empty())
.unwrap_or_else(|| agent_message.clone())
} else {
agent_message
};
let conversation_message = ChatMessage {
id: 0,
role: ChatRole::Agent,
message: agent_message,
message: event_message,
time: timestamp.to_string(),
};
if last_is_user || chat.messages.is_empty() {
chat.messages.push(conversation_message);
} else {
if chat
.messages
.last()
.is_some_and(|message| message.role == ChatRole::Agent && message.message.is_empty())
{
let last = chat.messages.len() - 1;
chat.messages[last] = conversation_message;
} else {
chat.messages.push(conversation_message);
}
reindex(&mut chat.messages);
}
Expand Down Expand Up @@ -579,7 +598,7 @@ mod tests {
}

#[test]
fn later_screen_updates_replace_current_agent_message() {
fn later_screen_updates_create_separate_timestamped_messages() {
let mut chat = sample_chat();
let before = "hi";
note_user_message(&mut chat, before, "hello", "t1");
Expand All @@ -590,14 +609,15 @@ mod tests {
.iter()
.filter(|m| m.role == ChatRole::Agent)
.collect();
assert_eq!(agents.last().unwrap().message, "partial reply done");
assert_eq!(agents[agents.len() - 2].message, "partial");
assert_eq!(agents.last().unwrap().message, "reply done");
assert_eq!(
chat
.messages
.iter()
.filter(|m| m.role == ChatRole::Agent)
.count(),
2
3
);
}

Expand Down
70 changes: 70 additions & 0 deletions src/components/LogFeed.test.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
import userEvent from "@testing-library/user-event";
import { describe, expect, it, vi } from "vitest";
import { render, screen } from "../../test/test-utils";
import type { LogRecordView } from "../lib/api-types";
import { LogFeed } from "./LogFeed";

const records: LogRecordView[] = [
{
timestamp: "2026-01-01T12:00:00Z",
severity_number: 9,
severity_text: "INFO",
body: "first searchable message",
trace_id: "trace",
span_id: "span",
run_id: 1,
job_id: "job",
step_index: 0,
step_name: "step",
stream: "stdout",
},
{
timestamp: "2026-01-01T12:00:01Z",
severity_number: 9,
severity_text: "INFO",
body: "second message",
trace_id: "trace",
span_id: "span-2",
run_id: 1,
job_id: "job",
step_index: 0,
step_name: "step",
stream: "stdout",
},
];

function feed(onSendToAgent = vi.fn()) {
render(
<LogFeed
records={records}
testId="feed"
lineTestId="line"
emptyMessage="Empty"
onSendToAgent={onSendToAgent}
/>,
);
return onSendToAgent;
}

describe("LogFeed", () => {
it("shows inspection and send action only for one selected row", async () => {
const user = userEvent.setup();
const send = feed();
expect(screen.queryByTestId("send-to-agent")).toBeNull();
await user.click(screen.getAllByTestId("line")[0]);
expect(screen.getByTestId("log-inspect-panel")).toHaveTextContent(
"first searchable message",
);
await user.click(screen.getByTestId("send-to-agent"));
expect(send).toHaveBeenCalledWith([records[0]]);
});

it("opens VSCode-style find with Ctrl+F and highlights matches", async () => {
const user = userEvent.setup();
feed();
await user.keyboard("{Control>}f{/Control}");
await user.type(screen.getByPlaceholderText("Find"), "searchable");
expect(screen.getByText("searchable").tagName).toBe("MARK");
expect(screen.getByText("1 of 1")).toBeTruthy();
});
});
Loading
Loading