Repository navigation
[INF-8243] Disable service links on agent sandbox pods - #410
Merged
Merged
Conversation
Sandbox pods were inheriting a *_SERVICE_HOST/*_PORT env var for every Service in their namespace, which sandbox code can't use, and shouldn't see.
Contributor
 [Medium impact] This PR appears safe to merge. Reviews (1) · Last reviewed commit: "[INF-8243] Disable service links on agen..." · Reviewed by Greptile |
anniej42
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
enableServiceLinks: falseon the agent sandbox Job template's pod spec.Sandbox pods were inheriting a
*_SERVICE_HOST/*_PORTenv var for every Service in their namespace, none of which sandbox code can reach (private IP ranges are blackholed by default). This also speeds up the start time of new sandbox pods in namespaces with many Services.Test plan: rendered the chart with
ci/test-agent-sandbox-enabled-option.yaml;job-template.jsonparses and the pod spec hasenableServiceLinks: false.