Repository navigation
Add eight bullet connector sizes with independent end genders - #8
Merged
Merged
Conversation
This was referenced Oct 6, 2026
Merged
seveibar
marked this pull request as ready for review
October 6, 2026 20:44
Collaborator
|
Thank you for your contribution! 🎉 PR Rating: ⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define single/grouped solder bullet cables for 2, 3, 3.5, 4, 5, 5.5, 6, and 8 mm.
bullet_d3.5mmdescribes one male/female pair;bullet3_d3.5mmdescribes three pairs and three insulated wires. Both support explicit end genders, e.g.bullet3_d3.5mm_afemale_bmale. The object form acceptspinCount(1–16, default 1). Validate matching contact counts, diameters, and wire pitch.Add contact-count, diameter, and independent-gender controls to the playground. A separate bullet gallery and snapshot show actual meshes, both connector faces, all supported diameters, and the triple-wire example. The common cable examples, existing snapshot tests, and common snapshot are restored unchanged; the PNG matches its original Git blob byte for byte. The dedicated bullet snapshot test has a 30-second timeout. Dimensions describe representative solder contacts rather than manufacturer-specific parts.
Validation: native GitHub Actions tests, type checking, formatting, gallery build, and new package preview build pass. Snapshots were visually inspected. Use the immutable jscad-electronics PR preview while the mesh release is pending.
Bullet modifiers are named and order-independent:
dfor diameter,a/bfor endpoint genders. Require a diameter and reject positional, unknown, and duplicate parameters. Optional genders default independently.