Skip to content

Render explicitly selected assembly.cable models - #4416

Merged
seveibar merged 29 commits into
mainfrom
codex/bullet-connectors-20261006
Oct 7, 2026
Merged

seveibar merged 29 commits into
mainfrom
codex/bullet-connectors-20261006

Conversation

@seveibar

@seveibar seveibar commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Adds explicit model selection to the existing <assembly.cable> API:

<assembly.cable
  from=".J1"
  to=".J2"
  model="adaptercable_a(bullet3_d3.5mm_gfemale)_b(bullet3_d4mm_gfemale)"
/>

Cableprinter parses the model and provides each end’s dimensions for routing. The original string is saved in cad_cable.cableprinter_string. Omitting model retains the existing standard inference and validation. Existing standards and connector props are unchanged.

The regression test covers a mixed JST SH/PH cable and a three-contact adapter cable with plain PCB endpoints, with one annotated visual snapshot.

Validation: all ten test shards, type checking, formatting, the distribution smoke test, package preview, and Vercel deployment pass against the released dependencies.

Uses the released @tscircuit/props@^0.0.695.

@vercel

vercel Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
tscircuit-core-benchmarks Ready Ready Preview Oct 7, 2026 5:19am UTC

Request Review

@seveibar seveibar changed the title Support bullet connectors in assembly.cable Support single and grouped bullet cables in assembly.cable Oct 6, 2026
@seveibar seveibar changed the title Support single and grouped bullet cables in assembly.cable Support bullet adapter cables from named imported CAD connectors Oct 6, 2026
@seveibar seveibar changed the title Support generic adapter cables and named CAD cable endpoints Render explicitly selected assembly.cable models Oct 7, 2026
@seveibar
seveibar marked this pull request as ready for review October 7, 2026 05:07
@seveibar
seveibar merged commit 700f251 into main Oct 7, 2026
18 checks passed
@seveibar
seveibar deleted the codex/bullet-connectors-20261006 branch October 7, 2026 06:44
@tscircuitbot

Copy link
Copy Markdown
Contributor

Thank you for your contribution! 🎉

PR Rating: ⭐⭐
Impact: Minor

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


This branch was successfully deployed

1 active deployment
Preview — b42673c1 Deployed Oct 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants