Repository navigation
Render explicitly selected assembly.cable models - #4416
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Oct 6, 2026
seveibar
marked this pull request as ready for review
October 7, 2026 05:07
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds explicit model selection to the existing
<assembly.cable>API:Cableprinter parses the model and provides each end’s dimensions for routing. The original string is saved in
cad_cable.cableprinter_string. Omittingmodelretains the existing standard inference and validation. Existing standards and connector props are unchanged.The regression test covers a mixed JST SH/PH cable and a three-contact adapter cable with plain PCB endpoints, with one annotated visual snapshot.
Validation: all ten test shards, type checking, formatting, the distribution smoke test, package preview, and Vercel deployment pass against the released dependencies.
Uses the released
@tscircuit/props@^0.0.695.