Repository navigation
Conversation
phndiaye
force-pushed
the
pn/migrate-to-v2-authoring-format
branch
from
November 11, 2026 07:18
cc9e7b5 to
b9413ea
Compare
4 of 8 tasks
Base automatically changed from
pn/ember-6-12-green
to
feature/ember-upgrade-4-to-7
November 12, 2026 19:37
Move the addon, standalone test app, Storybook, and supporting tooling into a pnpm workspace. Publish compiled modules and declarations through canonical exports while preserving resolver registrations, styles, translations, and OSS-owned assets. BREAKING CHANGE: consumers use canonical imports and styles paths, supply FontAwesome, and configure asset-map integration explicitly.
Cover the eight component aliases, named helper exports, relocated templates, truncate, translations, and initializer registration through the standalone test application.
- @embroider/addon-dev 8.5 (same rollup API, still `glint --declaration`). - Addon peer ember-source ^6.12.0; README compatibility updated. - The test app bundles sinon's self-contained ESM build: its Node entry needs a `util` polyfill that webpack 5 does not provide, which only resolved before through Storybook 6's dependency tree. - Lockfile regenerated. ember-auto-import ^2.13.1, ember-cli-htmlbars ^7.0.1 and the rest of the Ember 6.12 / Storybook 9 versions already come from the rebase onto pn/ember-6-12-green, as does the CI workflow (reusable test workflow, pre-release guard on the Storybook deploy).
…k it
no-positive-tabindex only accepts literal values (or if/unless with literal
branches), so `tabindex={{this.optionLabelTabIndex}}` failed lint:hbs. Same
values as before: -1 when disabled, 0 otherwise.
…ard operable When the content is truncated the root element gets role="button", but it could not be focused or toggled from the keyboard, which is what no-invalid-interactive reported. It now also gets tabindex="0" and toggles on Enter and Space. Short or non-collapsible feedback is unchanged: no role, no tabindex, keys are ignored.
The symlink regression tests master added to tests/build/asset-map-test.cjs merge their fixture trees with broccoli-merge-trees, but the v2 split had moved that package to the test-app along with the v1 index.js, so the addon's test:asset-map-build step failed with "Cannot find module".
Carry over what master changed in the files this branch moved or rewrote: version 4.0.0 (was 4.0.0-beta.3) for the addon and the test app, Node 24 or later in the addon's engines, and the refreshed README compatibility notes (Ember 6.12+, Node 24+, pnpm 10, ember-source peer, 3.x for older Ember).
phndiaye
force-pushed
the
pn/migrate-to-v2-authoring-format
branch
from
November 14, 2026 06:43
89cdfa4 to
fd06523
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Move the addon, test app, Storybook, and supporting tooling into a pnpm workspace. Publish compiled modules and declarations through explicit exports while preserving components/services/helpers/etc., styles, translations, and OSS-owned assets.
Important
BREAKING CHANGE: consumers use canonical imports and styles paths.
What are the observable changes?
Good PR checklist
Rebase note
Rebased onto the top of the Ember 6.12 stack (
pn/ember-6-12-green, #740) so the diff only shows the v2 migration. The original commits carry the stack's changes at their new paths; the last commit,build: move the v2 workspace onto the Ember 6.12 toolchain, bumps@embroider/addon-devto 8.5, sets theember-source ^6.12.0peer and regenerates the lockfile. Tests: 4090/4090, same count as the stack top.