Skip to content

Add ci+setup benchmark variation #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evert merged 3 commits into from
Sep 30, 2026
Merged

Add ci+setup benchmark variation #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ba05c3
Add ci+setup benchmark variation
vltbaudbot Sep 30, 2026
d2d99f0
Address review: isolate corepack/npm/zpm setup, fix average consistency
vltbaudbot Sep 30, 2026
f0c4e71
Address Copilot review: cache isolation, error propagation, per-PM pr…
vltbaudbot Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/benchmark.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
default: '["next", "astro", "vue", "svelte", "large", "babylon"]'
variations:
description: "The benchmark variations to run (build/build-cache/run are added via matrix include pairs)"
default: '["clean", "node_modules", "cache", "cache+node_modules", "cache+lockfile", "cache+lockfile+node_modules", "ci", "lockfile", "lockfile+node_modules", "registry-clean", "registry-lockfile"]'
default: '["clean", "node_modules", "cache", "cache+node_modules", "cache+lockfile", "cache+lockfile+node_modules", "ci", "ci+setup", "lockfile", "lockfile+node_modules", "registry-clean", "registry-lockfile"]'
binaries:
description: "The binaries to run the benchmarks on"
default: '"npm,yarn,berry,zpm,pnpm,pacquet,vlt,bun,deno,aube,upm,nx,turbo,vp,node"'
Expand Down Expand Up @@ -93,7 +93,7 @@ jobs:
partial=false
if [[ "${{ github.event_name }}" == "workflow_dispatch" ]]; then
[[ "$IN_FIXTURES" == '["next", "astro", "vue", "svelte", "large", "babylon"]' ]] || partial=true
[[ "$IN_VARIATIONS" == '["clean", "node_modules", "cache", "cache+node_modules", "cache+lockfile", "cache+lockfile+node_modules", "ci", "lockfile", "lockfile+node_modules", "registry-clean", "registry-lockfile"]' ]] || partial=true
[[ "$IN_VARIATIONS" == '["clean", "node_modules", "cache", "cache+node_modules", "cache+lockfile", "cache+lockfile+node_modules", "ci", "ci+setup", "lockfile", "lockfile+node_modules", "registry-clean", "registry-lockfile"]' ]] || partial=true
[[ "$IN_BINARIES" == '"npm,yarn,berry,zpm,pnpm,pacquet,vlt,bun,deno,aube,upm,nx,turbo,vp,node"' ]] || partial=true
[[ "$IN_WARMUP" == "2" ]] || partial=true
[[ "$IN_RUNS" == "5" ]] || partial=true
Expand All @@ -114,7 +114,7 @@ jobs:
fail-fast: false
matrix:
fixture: ${{ fromJson((github.event_name == 'push' && github.ref != 'refs/heads/main') && '["next", "astro", "vue", "svelte"]' || (inputs.fixtures || '["next", "astro", "vue", "svelte", "large", "babylon"]')) }}
variation: ${{ fromJson(inputs.variations || '["clean", "node_modules", "cache", "cache+node_modules", "cache+lockfile", "cache+lockfile+node_modules", "ci", "lockfile", "lockfile+node_modules", "registry-clean", "registry-lockfile"]') }}
variation: ${{ fromJson(inputs.variations || '["clean", "node_modules", "cache", "cache+node_modules", "cache+lockfile", "cache+lockfile+node_modules", "ci", "ci+setup", "lockfile", "lockfile+node_modules", "registry-clean", "registry-lockfile"]') }}
include:
- variation: "build"
fixture: "next"
Expand Down
2 changes: 2 additions & 0 deletions app/src/lib/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ export const getVariationCategories = (
"cache+lockfile",
"cache+lockfile+node_modules",
"ci",
"ci+setup",
"lockfile",
"lockfile+node_modules",
].filter((v) => variations.includes(v as Variation)) as Variation[];
Expand Down Expand Up @@ -412,6 +413,7 @@ export function sortVariations(variations: Variation[]): Variation[] {
"cache+lockfile",
"cache+lockfile+node_modules",
"ci",
"ci+setup",
"lockfile",
"lockfile+node_modules",
"build",
Expand Down
2 changes: 2 additions & 0 deletions app/src/types/chart-data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export type Variation =
| "cache+lockfile+node_modules"
| "cache+node_modules"
| "ci"
| "ci+setup"
| "clean"
| "lockfile"
| "lockfile+node_modules"
Expand Down Expand Up @@ -283,6 +284,7 @@ export function isValidVariation(variation: string): variation is Variation {
"cache+lockfile+node_modules",
"cache+node_modules",
"ci",
"ci+setup",
"clean",
"lockfile",
"lockfile+node_modules",
Expand Down
1 change: 1 addition & 0 deletions bench
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ AVAILABLE_VARIATIONS=(
cache+node_modules
cache+lockfile+node_modules
ci
ci+setup
lockfile
lockfile+node_modules
node_modules
Expand Down
3 changes: 3 additions & 0 deletions scripts/benchmark.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ case "$2" in
ci)
bash ../../scripts/variations/ci.sh "../../scripts" "../../results" "$1" "$2"
;;
ci+setup)
bash ../../scripts/variations/ci+setup.sh "../../scripts" "../../results" "$1" "$2"
;;
lockfile)
bash ../../scripts/variations/lockfile.sh "../../scripts" "../../results" "$1" "$2"
;;
Expand Down
1 change: 1 addition & 0 deletions scripts/generate-chart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ function generateChartData(option = {}) {
"cache+lockfile+node_modules",
"cache+node_modules",
"ci",
"ci+setup",
"clean",
"lockfile",
"lockfile+node_modules",
Expand Down
2 changes: 1 addition & 1 deletion scripts/process-results.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ echo "Processing results..."

# Process variations results
for fixture in next astro svelte vue large babylon; do
for variation in cache cache+lockfile cache+lockfile+node_modules cache+node_modules ci clean lockfile lockfile+node_modules node_modules build build-cache run; do
for variation in cache cache+lockfile cache+lockfile+node_modules cache+node_modules ci ci+setup clean lockfile lockfile+node_modules node_modules build build-cache run; do
if benchmark_file=$(resolve_result_path "$fixture" "$variation" "benchmarks.json"); then
print_summary "$benchmark_file" "$fixture" "$variation"
cp "$benchmark_file" "results/$DATE/$fixture-$variation.json"
Expand Down
Loading
Loading