Repository navigation
fix: drop Changesets from the vland monorepo template and allow lefthook's build with allowBuilds - #286
Merged
Conversation
Every package in the monorepo template is private and it has no release workflow, so Changesets had nothing to version or publish. Only the library template ships ready to publish to npm. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EZVC7xzzsEmByszmfff4u2
pnpm prefers allowBuilds since 10.26 and pnpm 11 removed onlyBuiltDependencies, so a generated project that moves to pnpm 11 fails its install on lefthook's build script and never gets the git hooks. The monorepo also drops @biomejs/biome, which has had no install script since Biome 2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EZVC7xzzsEmByszmfff4u2
🦋 Changeset detectedLatest commit: 5bbe280 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Preview releaseLatest commit: Some packages have been released:
Note Use the PR number as tag to install any package. For instance: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two template fixes, one commit each. Neither needs a vland CLI change: vland downloads templates from main, so they reach every installed vland as soon as this merges.
1. The monorepo template no longer ships Changesets. All of its packages are
privateand it has no release workflow. Only the library template is meant to be published, and it keeps its.changeset/andrelease.yml.2. All three templates allow lefthook's build with
allowBuilds.onlyBuiltDependenciesis the legacy key, and pnpm 11 drops it without a warning. ItsstrictDepBuildsthen makespnpm installfail (ERR_PNPM_IGNORED_BUILDS), so the git hooks are never installed. The templates pin pnpm 10.30.3, andallowBuildsexists since 10.26.Evidence
Each case runs a real
vland init <name> --template <t> --install --git </dev/nullwithVLAND_TEMPLATES_DIRset to this branch's templates, on pnpm 10.30.3:.git/hooks/pre-commitand.git/hooks/pre-push.pnpm-workspace.yamlhasallowBuildsand noonlyBuiltDependencies. After the README'srr plugins addsteps,rr checkpasses..changeset/, no@changesets/*in any package.json, andgit ls-files | xargs grep -il changesetfinds nothing.pnpm buildandpnpm testpass.pnpm installexits 1 withERR_PNPM_IGNORED_BUILDSand no hooks are installed.After, on pnpm 11 with
allowBuilds: lefthook builds and the hooks are installed.init-templates.test.ts: reverting only the template changes fails exactly the 4 new assertions, one for the monorepo and three for allowBuilds.Merge Danger
Door: two-way
Blast Radius: small
🤖 Generated with Claude Code
https://claude.ai/code/session_01EZVC7xzzsEmByszmfff4u2