Repository navigation
fix(semgrep): include PCP fixture pointers in scans (SEC-3328) - #1473
Open
NnnOooPppEee wants to merge 2 commits into
Open
NnnOooPppEee wants to merge 2 commits into
NnnOooPppEee wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
vmenge
approved these changes
Nov 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SEC-3328
Semgrep's default
tests/exclusions skippcp/tests/fixtures/, so the PCP pointer rule in security PR #267 would not receive these files during a normal directory scan.Add
.semgrepignoreusing Semgrep 1.168.0's default exclusions, then narrowly includepcp/tests/fixtures/**. Other PCP tests and unrelated test/build/vendor paths remain excluded. This requires Semgrepignore v2; managed project/global ignores must also allow the fixture paths. This changes scan selection only and does not download, unpack, or modify fixtures.Validation: three synthetic directory scans with Semgrep 1.168.0. All five fixture paths were included, including
.tar.gzand nested test directories; nine unrelated paths stayed excluded; zero scan errors. Whitespace checks passed. No application code changed.AI assistance was used to prepare and validate this change.